Re: [exec] Looking for some field testing before cutting release candidate ...

2010-10-02 Thread Gary Gregory
IMO we should bury support for 1.3.1, gently tap the dirt with our shovels and say thank you 1.3.1 and rest in peace. Gary On Oct 2, 2010, at 11:01, "Niall Pemberton" wrote: > Siegfried, > > I re-built the tests.zip from trunk with the JDK 1.3 fix[1] and using > m2 (with assembly patch[2]) a

Re: [Math] Code review

2010-10-02 Thread Phil Steitz
On 10/2/10 3:25 PM, Ted Dunning wrote: Another option is to have a small community of activists who are willing to comb the code and improve it without requiring everybody to catch all these issues. If what you mean by this is that we don't expect committers to fix checkstyle / findbugs error

Re: [Math] Code review

2010-10-02 Thread Ted Dunning
Another option is to have a small community of activists who are willing to comb the code and improve it without requiring everybody to catch all these issues. On Sat, Oct 2, 2010 at 8:37 AM, Phil Steitz wrote: > From my perspective, checkstyle.xml effectively represents our coding style > rules

[continuum] BUILD FAILURE: Apache Commons - Commons Lang - Default Maven 2 Build Definition (Java 1.5)

2010-10-02 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=818&projectId=95 Build statistics: State: Failed Previous State: Ok Started at: Sat 2 Oct 2010 19:20:46 + Finished at: Sat 2 Oct 2010 19:22:36 + Total time: 1m 49s Build Trigger: Schedule Build Nu

Re: [exec] Looking for some field testing before cutting release candidate ...

2010-10-02 Thread Niall Pemberton
Siegfried, I re-built the tests.zip from trunk with the JDK 1.3 fix[1] and using m2 (with assembly patch[2]) and got the following for JDK 1.3-1.6 [1] http://svn.apache.org/viewvc?view=revision&revision=1003818 [2] https://issues.apache.org/jira/browse/EXEC-48 OS: Windows 7 Enterprise JVM: 1.6.

Re: [Math] Code review

2010-10-02 Thread Phil Steitz
On 10/1/10 5:23 PM, Gilles Sadowski wrote: On Fri, Oct 01, 2010 at 04:05:11PM -0500, Brent Worden wrote: On Fri, Oct 1, 2010 at 9:27 AM, Gilles Sadowski wrote: Do you review the code manually, or do you use a tool to spot all these potential problems? Eclipse reports these, and I inspect th

[EXEC] OpenVMS failures

2010-10-02 Thread sebb
I've tried running my modified copy of the test cases. The testExecuteWatchdogSync() also hangs on OpenVMS. Not sure where to put the timeouts for that yet, so I tried disabling it. I now get the following errors/failures: Time: 88.365 There were 4 errors: 1) testExecuteWatchdogAsync(org.apache.

Re: svn commit: r1003770 - in /commons/proper/daemon/trunk: RELEASE-NOTES.txt src/native/windows/src/service.c

2010-10-02 Thread Mladen Turk
On 10/02/2010 04:14 PM, sebb wrote: All correct, but this is according to the MSDN: 256 chars except '/' and '\\' (path separators) We add space cause we need that in service name from the process name guessing. If anything is about to fail, then the Win API call will fail and we'll log the reas

Re: [MATH] Change test code to remove fail("wrong exception type caught")

2010-10-02 Thread sebb
On 2 October 2010 15:08, Phil Steitz wrote: > On 10/1/10 10:52 AM, Luc Maisonobe wrote: >> >> Le 01/10/2010 16:34, Gilles Sadowski a écrit : >>> >>> On Fri, Oct 01, 2010 at 03:17:58PM +0100, sebb wrote: There are quite a few test cases that have code like: public void testSomet

Re: svn commit: r1003770 - in /commons/proper/daemon/trunk: RELEASE-NOTES.txt src/native/windows/src/service.c

2010-10-02 Thread sebb
On 2 October 2010 15:06, Mladen Turk wrote: > On 10/02/2010 03:16 PM, sebb wrote: >> >> Not sure that is entirely safe? >> AFAICT, the service name can now contain arbitrary non-alphanumeric >> characters, including control chars. >> For example, I don't think it's wise to allow>  <  or | - and th

Re: [MATH] Change test code to remove fail("wrong exception type caught")

2010-10-02 Thread Phil Steitz
On 10/1/10 10:52 AM, Luc Maisonobe wrote: Le 01/10/2010 16:34, Gilles Sadowski a écrit : On Fri, Oct 01, 2010 at 03:17:58PM +0100, sebb wrote: There are quite a few test cases that have code like: public void testSomething(){ try { something(); fail("an exception should have

Re: svn commit: r1003770 - in /commons/proper/daemon/trunk: RELEASE-NOTES.txt src/native/windows/src/service.c

2010-10-02 Thread Mladen Turk
On 10/02/2010 03:16 PM, sebb wrote: Not sure that is entirely safe? AFAICT, the service name can now contain arbitrary non-alphanumeric characters, including control chars. For example, I don't think it's wise to allow> < or | - and there are probably others. All correct, but this is accord

Re: svn commit: r1003770 - in /commons/proper/daemon/trunk: RELEASE-NOTES.txt src/native/windows/src/service.c

2010-10-02 Thread sebb
On 2 October 2010 11:44, wrote: > Author: mturk > Date: Sat Oct  2 10:44:05 2010 > New Revision: 1003770 > > URL: http://svn.apache.org/viewvc?rev=1003770&view=rev > Log: > Partially fix DAEMON-164, The service names cannot have spaces however > > Modified: >    commons/proper/daemon/trunk/RELEAS

Re: [exec] Looking for some field testing before cutting release candidate ...

2010-10-02 Thread sebb
On 1 October 2010 18:20, Siegfried Goeschl wrote: >  Hi folks, > > anyone out who can do some field testing for commons-exec before I prepare > the release candidate? > > The test harness can be downloaded from > > http://people.apache.org/~sgoeschl/download/exec/ > > After unpacking the archive a

[g...@vmgump]: Project commons-javaflow (in module commons-sandbox) failed

2010-10-02 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-javaflow has an issue affecting its community integration. This is

[g...@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2010-10-02 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This

Re: [exec] Looking for some field testing before cutting release candidate ...

2010-10-02 Thread Jörg Schaible
Siegfried Goeschl wrote: > Hi folks, > > anyone out who can do some field testing for commons-exec before I > prepare the release candidate? > > The test harness can be downloaded from > > http://people.apache.org/~sgoeschl/download/exec/ > > After unpacking the archive and making the shell

[GUMP@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2010-10-02 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-scxml-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project commons-io-test (in module apache-commons) failed

2010-10-02 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-io-test has an issue affecting its community integration. This iss