Re: [Math] Code review

2010-10-01 Thread Ted Dunning
On Fri, Oct 1, 2010 at 3:22 PM, sebb wrote: > On 1 October 2010 22:54, Ted Dunning wrote: > > In Mahout, we have found that IntelliJ (which is usually like Eclipse, > but > > more thorough) does not warn on the same things > > that findbugs, pmd or checkstyle warn on. We haven't been able to fo

Re: [Math] Code review

2010-10-01 Thread sebb
On 1 October 2010 22:54, Ted Dunning wrote: > In Mahout, we have found that IntelliJ (which is usually like Eclipse, but > more thorough) does not warn on the same things > that findbugs, pmd or checkstyle warn on.  We haven't been able to force > that behavior very well, either.  That means that

Re: [Math] Code review

2010-10-01 Thread Ted Dunning
In Mahout, we have found that IntelliJ (which is usually like Eclipse, but more thorough) does not warn on the same things that findbugs, pmd or checkstyle warn on. We haven't been able to force that behavior very well, either. That means that we have to use a combination of methods to drive down

Re: [Math] Code review

2010-10-01 Thread Gilles Sadowski
On Fri, Oct 01, 2010 at 04:05:11PM -0500, Brent Worden wrote: > On Fri, Oct 1, 2010 at 9:27 AM, Gilles Sadowski > wrote: > >> > Do you review the code manually, or do you use a tool to spot all these > >> > potential problems? > >> > >> Eclipse reports these, and I inspect them manually before com

Re: [Math] Code review

2010-10-01 Thread Brent Worden
On Fri, Oct 1, 2010 at 9:27 AM, Gilles Sadowski wrote: >> > Do you review the code manually, or do you use a tool to spot all these >> > potential problems? >> >> Eclipse reports these, and I inspect them manually before committing. > > Isn't there some plugin such as CheckStyle or FindBugs that c

RE: [exec] Looking for some field testing before cutting release candidate ...

2010-10-01 Thread Gary Gregory
Microsoft Windows Vista Business N Service Pack 2 a.k.a. Microsoft Windows [Version 6.0.6002] java version "1.6.0_21" Java(TM) SE Runtime Environment (build 1.6.0_21-b07) Java HotSpot(TM) 64-Bit Server VM (build 17.0-b17, mixed mode) Gary Gregory OK (81 tests) -Original Message- From:

RE: [exec] Looking for some field testing before cutting release candidate ...

2010-10-01 Thread Gary Gregory
In the bat file you need to change the java invocation to: "%JAVA_HOME%\bin\java" in order to account for spaces in directory names. Gary Gregory Senior Software Engineer Rocket Software 3340 Peachtree Road, Suite 820 . Atlanta, GA 30326 . USA Email: ggreg...@seagullsoftware.com Web: seagull.roc

Re: [exec] Looking for some field testing before cutting release candidate ...

2010-10-01 Thread Simone Tripodi
Here I am!!! $ uname -a Darwin Simones-Computer-2.local 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386 $ java -version java version "1.5.0_24" Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_24-b02-357-10M3065) Java HotSpot(T

Re: [MATH] don't know how to fix UnivariateRealSolverUtilsTest.java test failures

2010-10-01 Thread Luc Maisonobe
Le 01/10/2010 19:09, Gilles Sadowski a écrit : >>> public void testSolveBadAccuracy() throws MathException { >>> try { // bad accuracy >>> UnivariateRealSolverUtils.solve(sin, 0.0, 4.0, 0.0); >> >> I guess this one cannot be triggered anymore since changes to >> convergence

Re: [exec] Looking for some field testing before cutting release candidate ...

2010-10-01 Thread James Carman
$ uname -a Linux carman-op755 2.6.34.7-56.fc13.x86_64 #1 SMP Wed Sep 15 03:36:55 UTC 2010 x86_64 x86_64 x86_64 GNU/Linux $ java -version java version "1.6.0_20" Java(TM) SE Runtime Environment (build 1.6.0_20-b02) Java HotSpot(TM) 64-Bit Server VM (build 16.3-b01, mixed mode) James Carman OK (81

[exec] Looking for some field testing before cutting release candidate ...

2010-10-01 Thread Siegfried Goeschl
Hi folks, anyone out who can do some field testing for commons-exec before I prepare the release candidate? The test harness can be downloaded from http://people.apache.org/~sgoeschl/download/exec/ After unpacking the archive and making the shell scripts (check src/test/scripts) executable

Re: [MATH] don't know how to fix UnivariateRealSolverUtilsTest.java test failures

2010-10-01 Thread Gilles Sadowski
> > public void testSolveBadAccuracy() throws MathException { > > try { // bad accuracy > > UnivariateRealSolverUtils.solve(sin, 0.0, 4.0, 0.0); > > I guess this one cannot be triggered anymore since changes to > convergence behavior. The ConvergingAlgorithm that provides t

[continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)

2010-10-01 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=798&projectId=97 Build statistics: State: Failed Previous State: Failed Started at: Fri 1 Oct 2010 16:20:59 + Finished at: Fri 1 Oct 2010 16:22:55 + Total time: 1m 55s Build Trigger: Schedule Buil

Re: [MATH] don't know how to fix UnivariateRealSolverUtilsTest.java test failures

2010-10-01 Thread Luc Maisonobe
Le 01/10/2010 17:01, sebb AT ASF a écrit : > The following tests were updated recently to add fail() calls, but the > IAE is not generated. > > Anyone have an idea how to fix the tests so the IAE is thrown? > > public void testSolveBadEndpoints() throws MathException { > try { // bad

[continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)

2010-10-01 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=797&projectId=97 Build statistics: State: Failed Previous State: Failed Started at: Fri 1 Oct 2010 15:31:34 + Finished at: Fri 1 Oct 2010 15:33:29 + Total time: 1m 54s Build Trigger: Schedule Buil

Re: [MATH] don't know how to fix UnivariateRealSolverUtilsTest.java test failures

2010-10-01 Thread Gilles Sadowski
On Fri, Oct 01, 2010 at 04:01:21PM +0100, sebb AT ASF wrote: > The following tests were updated recently to add fail() calls, but the > IAE is not generated. > > Anyone have an idea how to fix the tests so the IAE is thrown? > > public void testSolveBadEndpoints() throws MathException { >

[MATH] don't know how to fix UnivariateRealSolverUtilsTest.java test failures

2010-10-01 Thread sebb AT ASF
The following tests were updated recently to add fail() calls, but the IAE is not generated. Anyone have an idea how to fix the tests so the IAE is thrown? public void testSolveBadEndpoints() throws MathException { try { // bad endpoints UnivariateRealSolverUtils.solve(sin

Re: [MATH] Change test code to remove fail("wrong exception type caught")

2010-10-01 Thread Luc Maisonobe
Le 01/10/2010 16:34, Gilles Sadowski a écrit : > On Fri, Oct 01, 2010 at 03:17:58PM +0100, sebb wrote: >> There are quite a few test cases that have code like: >> >> public void testSomething(){ >> try { >> something(); >> fail("an exception should have been caught"); >> } catch

Re: [MATH] Change test code to remove fail("wrong exception type caught")

2010-10-01 Thread sebb
On 1 October 2010 15:34, Gilles Sadowski wrote: > On Fri, Oct 01, 2010 at 03:17:58PM +0100, sebb wrote: >> There are quite a few test cases that have code like: >> >> public void testSomething(){ >>     try { >>       something(); >>       fail("an exception should have been caught"); >>     } cat

[continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)

2010-10-01 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=795&projectId=97 Build statistics: State: Failed Previous State: Failed Started at: Fri 1 Oct 2010 14:38:34 + Finished at: Fri 1 Oct 2010 14:40:18 + Total time: 1m 43s Build Trigger: Forced Build

Re: [MATH] Change test code to remove fail("wrong exception type caught")

2010-10-01 Thread Gilles Sadowski
On Fri, Oct 01, 2010 at 03:17:58PM +0100, sebb wrote: > There are quite a few test cases that have code like: > > public void testSomething(){ > try { > something(); > fail("an exception should have been caught"); > } catch (EstimationException ee) { > // expected behavio

[continuum] BUILD FAILURE: Apache Commons - Commons Math - Default Maven 2 Build Definition (Java 1.5)

2010-10-01 Thread Continuum@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=794&projectId=97 Build statistics: State: Failed Previous State: Ok Started at: Fri 1 Oct 2010 14:31:47 + Finished at: Fri 1 Oct 2010 14:33:39 + Total time: 1m 52s Build Trigger: Schedule Build Nu

Re: [Math] Code review

2010-10-01 Thread Gilles Sadowski
> > Do you review the code manually, or do you use a tool to spot all these > > potential problems? > > Eclipse reports these, and I inspect them manually before committing. Isn't there some plugin such as CheckStyle or FindBugs that could be called from maven? Gilles -

[MATH] Change test code to remove fail("wrong exception type caught")

2010-10-01 Thread sebb
There are quite a few test cases that have code like: public void testSomething(){ try { something(); fail("an exception should have been caught"); } catch (EstimationException ee) { // expected behavior } catch (Exception e) { fail("wrong exception type caught"

Re: [Math] Code review (Was: Re: svn commit: r1003533 - ...)

2010-10-01 Thread sebb
On 1 October 2010 14:49, Gilles Sadowski wrote: > Hi. > >> URL: http://svn.apache.org/viewvc?rev=1003533&view=rev >> Log: >> Unnecessary cast >> >> [...] > > Do you review the code manually, or do you use a tool to spot all these > potential problems? Eclipse reports these, and I inspect them man

[Math] Code review (Was: Re: svn commit: r1003533 - ...)

2010-10-01 Thread Gilles Sadowski
Hi. > URL: http://svn.apache.org/viewvc?rev=1003533&view=rev > Log: > Unnecessary cast > > [...] Do you review the code manually, or do you use a tool to spot all these potential problems? Regards, Gilles - To unsubscribe, e-

[g...@vmgump]: Project commons-javaflow (in module commons-sandbox) failed

2010-10-01 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-javaflow has an issue affecting its community integration. This is

[g...@vmgump]: Project commons-proxy-test (in module apache-commons) failed

2010-10-01 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-proxy-test has an issue affecting its community integration. This

[ALL] Continuum builds - now default to Java 1.5

2010-10-01 Thread sebb
I have changed the Continuum build to default to using Java 1.5, since most projects use 1.5 or earlier. [The Continuum host does not support Java 1.4] The idea is to catch inadvertent use of Java 1.6+ methods and features. Builds that need Java 1.6 have been updated to add a project build defini

[g...@vmgump]: Project commons-scxml-test (in module apache-commons) failed

2010-10-01 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-scxml-test has an issue affecting its community integration. This

[continuum] BUILD FAILURE: Apache Commons - Commons Monitoring (Sandbox) - Default Maven 2 Build Definition (Java 1.5)

2010-10-01 Thread contin...@vmbuild
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=788&projectId=127 Build statistics: State: Failed Previous State: Failed Started at: Fri 1 Oct 2010 10:50:12 + Finished at: Fri 1 Oct 2010 10:50:59 + Total time: 47s Build Trigger: Forced Build Nu

[g...@vmgump]: Project commons-io-test (in module apache-commons) failed

2010-10-01 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-io-test has an issue affecting its community integration. This iss