Re: [COMPRESS] Add getArchiveType() method to [Archive|Compressor]InputStream classes?

2010-05-11 Thread Christian Grobmeier
On Tue, May 11, 2010 at 9:04 PM, Torsten Curdt wrote: > In the code we call it "Archivername". That should be changed > accordingly to "type" then IMO. (getArchiveName() could be a little > ambiguous) > no objections against the type, but: really change? I was thinking on backwards compatibility

Re: [COMPRESS] Add getArchiveType() method to [Archive|Compressor]InputStream classes?

2010-05-11 Thread Torsten Curdt
>>  IIUC you want the type of the archive, but we are dealing here with >>  Archiver implementations. In theory we could have 2 different >>  implementations for e.g. "zip". > > But they would both return "zip", which is what is wanted. That is the question. They could as well also be standard-z

Re: [COMPRESS] Add getArchiveType() method to [Archive|Compressor]InputStream classes?

2010-05-11 Thread sebb
On 11/05/2010, Torsten Curdt wrote: > >> That said: Is there a particular reason you need this? Or is this just > >> because you think it might be useful? > > > > I was thinking it would be useful for the proposed command-line > > utility - you could pass it any archive file and find out wha

Re: [COMPRESS] Add getArchiveType() method to [Archive|Compressor]InputStream classes?

2010-05-11 Thread Torsten Curdt
>>  That said: Is there a particular reason you need this? Or is this just >>  because you think it might be useful? > > I was thinking it would be useful for the proposed command-line > utility - you could pass it any archive file and find out what it is. Hm ...all you would get is the implementa

Re: [COMPRESS] Add getArchiveType() method to [Archive|Compressor]InputStream classes?

2010-05-11 Thread sebb
On 11/05/2010, Torsten Curdt wrote: > In the code we call it "Archivername". That should be changed > accordingly to "type" then IMO. (getArchiveName() could be a little > ambiguous) > > That said: Is there a particular reason you need this? Or is this just > because you think it might be usef

Re: [COMPRESS] Add getArchiveType() method to [Archive|Compressor]InputStream classes?

2010-05-11 Thread Torsten Curdt
In the code we call it "Archivername". That should be changed accordingly to "type" then IMO. (getArchiveName() could be a little ambiguous) That said: Is there a particular reason you need this? Or is this just because you think it might be useful? On Tue, May 11, 2010 at 17:55, sebb wrote: > S

[g...@vmgump]: Project commons-collections4 (in module apache-commons) failed

2010-05-11 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project commons-collections4 has an issue affecting its community integration. Thi

[COMPRESS] Add getArchiveType() method to [Archive|Compressor]InputStream classes?

2010-05-11 Thread sebb
Seems to me that it would be useful to be able to find out what ArchiveInputStream has been chosen by the ArchiveStreamFactory. I'm thinking of adding something like: public String getArchiveType() { return ArchiveStreamFactory.TAR ; // or ZIP etc. } to each of the AIS subclasses. The AIS pa