Re: [lang 3] Validate: rename methods

2009-11-29 Thread Henri Yandell
So classical OO naming convention. Class = noun Method = verb Validator.validateNotNull versus the non-OO Validate.notNull. Theoretically - sure. Reality? assertEquals only works in JUnit because it's in the inheritance chain. I think I'd dislike Asserter.assertEquals :) Hen On Sun, Nov 29

Re: [lang 3] Validate: rename methods

2009-11-29 Thread Paul Benedict
It is a verb, of course, but methods should be verbs. I am only appealing to the classical naming convention of methods. They do the work; classes don't. You can't ask a class to validate; you can ask its methods to validate. Paul On 11/30/2009 1:31 AM, Henri Yandell wrote: Validate isn't a

Re: [lang 3] Validate: rename methods

2009-11-29 Thread Henri Yandell
Validate isn't a verb? On Sun, Nov 29, 2009 at 9:06 PM, Paul Benedict wrote: > I am not catering to static imports. I am catering towards a > consistent naming convention. If you compare our names to what exists > in Spring's and Google's API, you will find that ours are not > verb-ified. The who

Re: [lang 3] Validate: rename methods

2009-11-29 Thread Paul Benedict
I am not catering to static imports. I am catering towards a consistent naming convention. If you compare our names to what exists in Spring's and Google's API, you will find that ours are not verb-ified. The whole static import discussion is just an additional benefit. What I would like to focus

Re: [lang 3] Validate: rename methods

2009-11-29 Thread Henri Yandell
On Sun, Nov 29, 2009 at 1:32 PM, Paul Benedict wrote: > On Sun, Nov 29, 2009 at 3:26 PM, Stephen Colebourne > wrote: >> Paul Benedict wrote: >>> >>> I want to rename isTrue to validateArgument (which throws >>> IllegalArgumentException); then also introduce validateState (which throws >>> Illegal

Re: [lang 3] Validate: rename methods

2009-11-29 Thread Paul Benedict
On Sun, Nov 29, 2009 at 3:26 PM, Stephen Colebourne wrote: > Paul Benedict wrote: >> >> I want to rename isTrue to validateArgument (which throws >> IllegalArgumentException); then also introduce validateState (which throws >> IllegalStateException). > > We have this in a work version of this clas

Re: [lang 3] Validate: rename methods

2009-11-29 Thread Stephen Colebourne
Paul Benedict wrote: I want to rename isTrue to validateArgument (which throws IllegalArgumentException); then also introduce validateState (which throws IllegalStateException). We have this in a work version of this class, I'm not sure that it doesn't confuse the purpose of the class. As suc

Re: [io]New Functionality Submittal

2009-11-29 Thread David Armstrong
Commons IO Developers, I submitted a proposal for new Commons IO functionality a month ago and have still received no response. Can someone please give some feedback on the new code I have offered? https://issues.apache.org/jira/browse/IO-222 Thanks, David Armstrong On Tue, Nov 3, 2009 at 6:41

[lang 3] Validate: rename methods

2009-11-29 Thread Paul Benedict
I want to rename isTrue to validateArgument (which throws IllegalArgumentException); then also introduce validateState (which throws IllegalStateException). I also propose we rename the methods so that the verb "validate" prefixes them all (Google Collections uses "check"). Furthermore, this