Re: [dbcp] 1.3 release packaging - take two

2009-11-28 Thread Phil Steitz
Jörg Schaible wrote: > Niall Pemberton wrote: > >> 2009/11/28 Phil Steitz : > > [snip] > >>> I think adding this to the build.xml in trunk will be confusing. I >>> agree with Sebb that if we do that we need to comment it. Since we >>> are going to have to have a branch to cut the 1.3 release fr

Re: [dbcp] 1.3 release packaging - take two

2009-11-28 Thread Jörg Schaible
Niall Pemberton wrote: > 2009/11/28 Phil Steitz : [snip] >> I think adding this to the build.xml in trunk will be confusing. I >> agree with Sebb that if we do that we need to comment it.  Since we >> are going to have to have a branch to cut the 1.3 release from and >> we also need to change th

[DBCP] SQLNestedException & logging exceptions

2009-11-28 Thread Niall Pemberton
I have created a couple of issues (with patches) DBCP-310 - simplify SQLNestedException now that JDK 1.4 will be the minimum from DBCP 1.3 onwards and remove its deprecation DBCP-311 - don't log and re-throw exceptions (presumably this was from when JDK 1.3 was minimum) Is it too late (i.e. close

Re: [dbcp] 1.3 release packaging - take two

2009-11-28 Thread Niall Pemberton
2009/11/28 Phil Steitz : > Niall Pemberton wrote: >> 2009/11/28 Phil Steitz : >>> Niall Pemberton wrote: 2009/11/27 Phil Steitz : > Niall Pemberton wrote: >> 2009/11/27 Phil Steitz : >>> Niall Pemberton wrote: On Fri, Nov 27, 2009 at 8:47 AM, Jörg Schaible wrote

Re: [dbcp] 1.3 release packaging - take two

2009-11-28 Thread Phil Steitz
Niall Pemberton wrote: > 2009/11/28 Phil Steitz : >> Niall Pemberton wrote: >>> 2009/11/27 Phil Steitz : Niall Pemberton wrote: > 2009/11/27 Phil Steitz : >> Niall Pemberton wrote: >>> On Fri, Nov 27, 2009 at 8:47 AM, Jörg Schaible >>> wrote: Hi Grzegorz, >>

Re: [dbcp] 1.3 release packaging - take two

2009-11-28 Thread sebb
On 28/11/2009, Niall Pemberton wrote: > 2009/11/28 Phil Steitz : > > > Niall Pemberton wrote: > >> 2009/11/27 Phil Steitz : > >>> Niall Pemberton wrote: > 2009/11/27 Phil Steitz : > > Niall Pemberton wrote: > >> On Fri, Nov 27, 2009 at 8:47 AM, Jörg Schaible > wrote: > >>>

Re: [dbcp] 1.3 release packaging - take two

2009-11-28 Thread Niall Pemberton
2009/11/28 Phil Steitz : > Niall Pemberton wrote: >> 2009/11/27 Phil Steitz : >>> Niall Pemberton wrote: 2009/11/27 Phil Steitz : > Niall Pemberton wrote: >> On Fri, Nov 27, 2009 at 8:47 AM, Jörg Schaible >> wrote: >>> Hi Grzegorz, >>> >>> Grzegorz Słowikowski wrote a