Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Phil Steitz
Paul Benedict wrote: > When I was patching Hibernate, they needed different sources because > of JDBC3/4 incompatibility. It just wasn't possible to compile for > both dependencies. > > I just checked with Brett Porter of Maven. He says that if the sources > are identical, you can use qualifiers;

[lang 3] static or dynamic type checks?

2009-11-25 Thread Paul Benedict
If we want to implement LANG-508 (Validate: add message parameter construction via elllipsis notation to speed up processing), I am really concerned with the many overloaded versions of #validIndex() and #notEmpty() that solely differ by static argument type: Collection, Object, Object[], CharSeque

Re: [DBCP] Update dependency and plugin versions

2009-11-25 Thread Phil Steitz
sebb wrote: > I've updated the Commons Logging version, because that's obviously sensible. > > The Maven dependency checker suggests the following updates: > > org.apache.geronimo.modules:geronimo-transaction ... 1.2-beta -> 2.1.4 > (test scope) > org.apache.geronimo.specs:geronimo-jta_1.1_spec .

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Paul Benedict
When I was patching Hibernate, they needed different sources because of JDBC3/4 incompatibility. It just wasn't possible to compile for both dependencies. I just checked with Brett Porter of Maven. He says that if the sources are identical, you can use qualifiers; otherwise it would conflict when

Re: Publishing sandbox project

2009-11-25 Thread Niall Pemberton
On Wed, Nov 25, 2009 at 11:09 PM, Phil Steitz wrote: > Niall Pemberton wrote: >> On Wed, Nov 25, 2009 at 10:55 PM, Mladen Turk wrote: >>> On 11/25/2009 10:26 PM, Phil Steitz wrote: Done now.  The site is up at http://commons.apache.org/sandbox/runtime/ and the main commons site menus an

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Paul Benedict
Niall, Since the "sources" and "javadocs" are qualifiers, I am concerned there is an incompatibility here. I can't prove it, but I suspect there might be. Paul On Wed, Nov 25, 2009 at 6:51 PM, Niall Pemberton wrote: > On Thu, Nov 26, 2009 at 12:46 AM, Paul Benedict wrote: >> Does adding a clas

[DBCP] Update dependency and plugin versions

2009-11-25 Thread sebb
I've updated the Commons Logging version, because that's obviously sensible. The Maven dependency checker suggests the following updates: org.apache.geronimo.modules:geronimo-transaction ... 1.2-beta -> 2.1.4 (test scope) org.apache.geronimo.specs:geronimo-jta_1.1_spec . 1.1 -> 1.1.1 (opt

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Niall Pemberton
On Thu, Nov 26, 2009 at 12:46 AM, Paul Benedict wrote: > Does adding a classifier like "jdbc3" affect the creation of the > -source and -javadoc classifiers? I don't believe it should - those are produced by the sources and javadoc plugins respectively. In the commons build those plugins are conf

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Paul Benedict
Does adding a classifier like "jdbc3" affect the creation of the -source and -javadoc classifiers? On Wed, Nov 25, 2009 at 6:06 PM, Phil Steitz wrote: > Niall Pemberton wrote: >> On Wed, Nov 25, 2009 at 11:39 PM, Niall Pemberton >> wrote: >>> On Wed, Nov 25, 2009 at 11:31 PM, Phil Steitz wrote:

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Phil Steitz
Niall Pemberton wrote: > On Wed, Nov 25, 2009 at 11:39 PM, Niall Pemberton > wrote: >> On Wed, Nov 25, 2009 at 11:31 PM, Phil Steitz wrote: >>> Niall Pemberton wrote: On Wed, Nov 25, 2009 at 10:23 PM, Paul Benedict wrote: > Phil, > > I don't think you should be modifying t

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Niall Pemberton
On Wed, Nov 25, 2009 at 11:39 PM, Niall Pemberton wrote: > On Wed, Nov 25, 2009 at 11:31 PM, Phil Steitz wrote: >> Niall Pemberton wrote: >>> On Wed, Nov 25, 2009 at 10:23 PM, Paul Benedict >>> wrote: Phil, I don't think you should be modifying the version (and groups, really) >>

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Niall Pemberton
On Wed, Nov 25, 2009 at 11:31 PM, Phil Steitz wrote: > Niall Pemberton wrote: >> On Wed, Nov 25, 2009 at 10:23 PM, Paul Benedict wrote: >>> Phil, >>> >>> I don't think you should be modifying the version (and groups, really) >>> here. All the artifacts belong to version 1.3. >>> >>> Maven does ha

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Paul Benedict
I think Niall has good counterpoints. I think his point is summed up with: * Keep same groupId * Keep same artifactId * Keep same version * Different classifiers are appropriate. If so, I am +1 with it. Paul On Wed, Nov 25, 2009 at 5:25 PM, Niall Pemberton wrote: > On Wed, Nov 25, 2009 at 10:2

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Phil Steitz
Niall Pemberton wrote: > On Wed, Nov 25, 2009 at 10:23 PM, Paul Benedict wrote: >> Phil, >> >> I don't think you should be modifying the version (and groups, really) >> here. All the artifacts belong to version 1.3. >> >> Maven does have a concept of a qualifier, but according to Sonatype, >> it's

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Niall Pemberton
On Wed, Nov 25, 2009 at 10:23 PM, Paul Benedict wrote: > Phil, > > I don't think you should be modifying the version (and groups, really) > here. All the artifacts belong to version 1.3. > > Maven does have a concept of a qualifier, but according to Sonatype, > it's only to capture milestone build

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Phil Steitz
Olivier Lamy wrote: > Hi Folks, > If you change groupId could you please provide a relocation pom in the > old groupId > commons-dbcp:commons-dbcp:1.3 -> org.apache.commons:commons-dbcp-jdbc3:1.3 Will do if we decide to go that route. Phil > > -- > Olivier > > 2009/11/26 Phil Steitz : >> Paul B

Re: Publishing sandbox project

2009-11-25 Thread Phil Steitz
Niall Pemberton wrote: > On Wed, Nov 25, 2009 at 10:55 PM, Mladen Turk wrote: >> On 11/25/2009 10:26 PM, Phil Steitz wrote: >>> Done now. The site is up at http://commons.apache.org/sandbox/runtime/ >>> and the main commons site menus and component table have been >>> updated (will take an hour o

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Paul Benedict
Correction: For users who use employ version ranges in their POMs like "[1.3,)" they are telling Maven they want >= 1.3. It is misleading -- I actually believe wrong -- to say that the "1.3-jdbc3" version is a greater version than than version "1.3". Paul On Wed, Nov 25, 2009 at 5:05 PM, Paul Be

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Olivier Lamy
Hi Folks, If you change groupId could you please provide a relocation pom in the old groupId commons-dbcp:commons-dbcp:1.3 -> org.apache.commons:commons-dbcp-jdbc3:1.3 -- Olivier 2009/11/26 Phil Steitz : > Paul Benedict wrote: >> Phil, >> >> I don't think you should be modifying the version (and

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Paul Benedict
Brent, If you haven't read the Sonatype link, it tells some important things about how the version number is interpreted by Maven. The standard is using 3 numbers, and it allows Maven to know that, for example, 1.3 < 1.4. But what happens if you version as "1.3-jdbc3"? Is anyone going to confident

Re: Publishing sandbox project

2009-11-25 Thread Niall Pemberton
On Wed, Nov 25, 2009 at 10:55 PM, Mladen Turk wrote: > On 11/25/2009 10:26 PM, Phil Steitz wrote: >>> >> Done now.  The site is up at http://commons.apache.org/sandbox/runtime/ >> and the main commons site menus and component table have been >> updated (will take an hour or so to replicate). >> >

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Phil Steitz
Paul Benedict wrote: > Phil, > > I don't think you should be modifying the version (and groups, really) > here. All the artifacts belong to version 1.3. > > Maven does have a concept of a qualifier, but according to Sonatype, > it's only to capture milestone builds: > http://www.sonatype.com/book

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Brent Worden
On Wed, Nov 25, 2009 at 4:23 PM, Paul Benedict wrote: > > Phil, > > I don't think you should be modifying the version (and groups, really) > here. All the artifacts belong to version 1.3. > > Maven does have a concept of a qualifier, but according to Sonatype, > it's only to capture milestone buil

Re: Publishing sandbox project

2009-11-25 Thread Mladen Turk
On 11/25/2009 10:26 PM, Phil Steitz wrote: Done now. The site is up at http://commons.apache.org/sandbox/runtime/ and the main commons site menus and component table have been updated (will take an hour or so to replicate). Excellent. Many thanks. Sorry the template was misleading and ou

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Paul Benedict
Phil, I don't think you should be modifying the version (and groups, really) here. All the artifacts belong to version 1.3. Maven does have a concept of a qualifier, but according to Sonatype, it's only to capture milestone builds: http://www.sonatype.com/books/maven-book/reference/pom-relationsh

Re: [dbcp] 1.3 release packaging - take two

2009-11-25 Thread Phil Steitz
Phil Steitz wrote: > I am about to roll an RC and I need to make sure all are OK with the > artifact names and repo placement > > JDBC 4 version (JDK 1.6) > groupId org.apache.maven Oops! I obviously mean commons above :) > artifactID commons-dbcp > version 1.3 > > JDBC 3 version (JDK 1.4-1.5)

[dbcp] 1.3 release packaging - take two

2009-11-25 Thread Phil Steitz
I am about to roll an RC and I need to make sure all are OK with the artifact names and repo placement JDBC 4 version (JDK 1.6) groupId org.apache.maven artifactID commons-dbcp version 1.3 JDBC 3 version (JDK 1.4-1.5) groupId commons-dbcp artifactId commons-dbcp version 1.3-jdbc3 Giving the 1.3

Re: Publishing sandbox project

2009-11-25 Thread Phil Steitz
Mladen Turk wrote: > On 11/25/2009 06:42 PM, Phil Steitz wrote: >> >> Would you be OK with maven 2 to build the runtime site? > > I really don't care. If maven2 is required, fine with me. > >> >> I can set this up for you, but to maintain it you will need maven 2. >> > > That would be perfect. >

Re: [DBCP] Proposed changes to Ant build file

2009-11-25 Thread Phil Steitz
sebb wrote: > At present, in order to build DBCP using Ant, one has to copy > build.properties.sample to build.properties otherwise none of the > dependencies are found. The build.properties.sample props only work if you have a m2 local repo. I would prefer to leave as is so user knows what they

[DBCP] Proposed changes to Ant build file

2009-11-25 Thread sebb
At present, in order to build DBCP using Ant, one has to copy build.properties.sample to build.properties otherwise none of the dependencies are found. Seems to me the Ant file should load properties from build.properties.sample immediately after loading from build.properties - if that exists. Bui

Re: [dbcp] 1.3 release problems

2009-11-25 Thread Phil Steitz
sebb wrote: > On 24/11/2009, Phil Steitz wrote: >> sebb wrote: >> > On 24/11/2009, sebb wrote: >> >> On 24/11/2009, Phil Steitz wrote: >> >> > Phil Steitz wrote: >> >> > > sebb wrote: >> >> > >> On 22/11/2009, Phil Steitz wrote: >> >> > >>> I am running into some problems preparing

Re: Publishing sandbox project

2009-11-25 Thread Mladen Turk
On 11/25/2009 06:42 PM, Phil Steitz wrote: Would you be OK with maven 2 to build the runtime site? I really don't care. If maven2 is required, fine with me. I can set this up for you, but to maintain it you will need maven 2. That would be perfect. Thanks -- ^TM --

Re: Publishing sandbox project

2009-11-25 Thread Phil Steitz
Mladen Turk wrote: > On 11/25/2009 04:02 PM, Phil Steitz wrote: >> >> Looks like [runtime] has a Maven 1 build. > > It doesn't. Those are generated files. > Build system will use ant with Runtime's own > ant extensions for making custom .jar files > containing both Java and Native components. > >

Re: [DBCP] Noisy test output

2009-11-25 Thread Phil Steitz
sebb wrote: > On 25/11/2009, Phil Steitz wrote: >> sebb wrote: >> > On 23/11/2009, sebb wrote: >> >> The JUnit tests produce a lot of output, even if the tests are >> successful. >> >> >> >> Is there really any need to print stack traces in the following method? >> >> >> >> TestSharedPoo

Re: [cli] (or [cli2]?) Plans for CLI 2.0 release?

2009-11-25 Thread Karl Heinz Marbaise
Hi Jukka, Hi, Apache Mahout is moving to fully a Maven-based build/release process and they're having problems with the commons-cli 2.0 dependency which I believe they get through Hadoop. To solve the dependency issue, Mahout has deployed that snapshot to Maven central as org.apache.mahout.comm

Re: [JEXL 2.0] o.a.c.jexl or o.a.c.jexl2 ?

2009-11-25 Thread henrib
Thanks Nial; package name change committed in trunk (http://svn.apache.org/viewvc?rev=884175&view=rev). -- View this message in context: http://n4.nabble.com/JEXL-2-0-o-a-c-jexl-or-o-a-c-jexl2-tp727081p787678.html Sent from the Commons - Dev mailing list archive at Nabble.com.

Re: [DBCP] Noisy test output

2009-11-25 Thread sebb
On 25/11/2009, Phil Steitz wrote: > sebb wrote: > > On 23/11/2009, sebb wrote: > >> The JUnit tests produce a lot of output, even if the tests are successful. > >> > >> Is there really any need to print stack traces in the following method? > >> > >> TestSharedPoolDataSource.PoolTest.run(

Re: [DBCP] Noisy test output

2009-11-25 Thread Phil Steitz
sebb wrote: > On 23/11/2009, sebb wrote: >> The JUnit tests produce a lot of output, even if the tests are successful. >> >> Is there really any need to print stack traces in the following method? >> >> TestSharedPoolDataSource.PoolTest.run() >> >> I propose to comment them out. >> >> Similarl

Re: Publishing sandbox project

2009-11-25 Thread Mladen Turk
On 11/25/2009 04:02 PM, Phil Steitz wrote: Looks like [runtime] has a Maven 1 build. It doesn't. Those are generated files. Build system will use ant with Runtime's own ant extensions for making custom .jar files containing both Java and Native components. Let me know if you have problems,

Re: [JEXL 2.0] o.a.c.jexl or o.a.c.jexl2 ?

2009-11-25 Thread Niall Pemberton
On Wed, Nov 25, 2009 at 2:56 PM, Niall Pemberton wrote: > On Wed, Nov 25, 2009 at 2:25 PM, henrib wrote: >> >> >> One last thing, just to be safe; if I was to perform the serie of 'svn >> mv...' on the java files in the trunk, anything that currently depends upon >> JEXL's trunk would stop compil

Re: Publishing sandbox project

2009-11-25 Thread Rahul Akolkar
On Wed, Nov 25, 2009 at 4:52 AM, Mladen Turk wrote: > Hi, > > I'd like to list the sandbox/runtime on the main commons page. > What's needed for that (given that I have xdocs directory and > index.xml in there) > Its slightly arcane, I'm afraid. Brief pointers below (I'm in a rush), feel free to

Re: Publishing sandbox project

2009-11-25 Thread Phil Steitz
Mladen Turk wrote: > Hi, > > I'd like to list the sandbox/runtime on the main commons page. > What's needed for that (given that I have xdocs directory and > index.xml in there) > > IMHO the project-template should include the skeleton > index.xml and sample resources (if that's how it's done) >

Re: [JEXL 2.0] o.a.c.jexl or o.a.c.jexl2 ?

2009-11-25 Thread Rahul Akolkar
On Wed, Nov 25, 2009 at 9:37 AM, sebb wrote: > On 25/11/2009, henrib wrote: >> >> >>  One last thing, just to be safe; if I was to perform the serie of 'svn >>  mv...' on the java files in the trunk, anything that currently depends upon >>  JEXL's trunk would stop compiling. > > Why? So long as t

Re: [JEXL 2.0] o.a.c.jexl or o.a.c.jexl2 ?

2009-11-25 Thread Niall Pemberton
On Wed, Nov 25, 2009 at 2:25 PM, henrib wrote: > > > One last thing, just to be safe; if I was to perform the serie of 'svn > mv...' on the java files in the trunk, anything that currently depends upon > JEXL's trunk would stop compiling. > > This would imply the gump/nightly commons builds that h

Re: [JEXL 2.0] o.a.c.jexl or o.a.c.jexl2 ?

2009-11-25 Thread sebb
On 25/11/2009, henrib wrote: > > > One last thing, just to be safe; if I was to perform the serie of 'svn > mv...' on the java files in the trunk, anything that currently depends upon > JEXL's trunk would stop compiling. Why? So long as the result of the commits was still consistent, I don't s

Re: [JEXL 2.0] o.a.c.jexl or o.a.c.jexl2 ?

2009-11-25 Thread henrib
One last thing, just to be safe; if I was to perform the serie of 'svn mv...' on the java files in the trunk, anything that currently depends upon JEXL's trunk would stop compiling. This would imply the gump/nightly commons builds that happily cope with the current JEXL trunk will fail forever

Publishing sandbox project

2009-11-25 Thread Mladen Turk
Hi, I'd like to list the sandbox/runtime on the main commons page. What's needed for that (given that I have xdocs directory and index.xml in there) IMHO the project-template should include the skeleton index.xml and sample resources (if that's how it's done) If anyone can explain how to create