Re: [compress] A few comments

2008-06-17 Thread Christian Grobmeier
Hi A higher level API to manipulate the archives would be nice, but I believe > an initial release could be made with just the stream classes. > Hm ...indeed. But IMO the changeset stuff is where it actually gets > interesting :) > changeset is great :-) however an initial release with the stre

Re: [compress] A few comments

2008-06-17 Thread Torsten Curdt
- the exceptions could extend IOException Could - but why restrict it that way? (composition over inheritance) - I'm not sure to understand the purpose of the jar classes, isn't a jar just a renamed zip ? Essentially - yes. But the JDK also handles them differently because of meta data an

[continuum] BUILD FAILURE: Commons - Commons Compress (Sandbox) - Build Def:

2008-06-17 Thread [EMAIL PROTECTED]
Online report : http://vmbuild.apache.org/continuum/buildResult.action?buildId=97436&projectId=176 Build statistics: State: Failed Previous State: Failed Started at: Tue 17 Jun 2008 11:52:06 -0700 Finished at: Tue 17 Jun 2008 11:52:34 -0700 Total time: 28s Build Trigger: Schedule Build Nu

Re: [compress] A few comments

2008-06-17 Thread Emmanuel Bourg
Christian Grobmeier a écrit : thanks for your comments below. They all make sense. I committed the changes to get a hand on the code, but I won't go farther since your code base is much more advanced. However, Thorsten and I currently develop a new and (hopefully) better implementation th

Re: [exec] Proposal - Moving commons-exec from sandbox to proper

2008-06-17 Thread James Carman
On Tue, Jun 17, 2008 at 8:30 AM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > On Tue, Jun 17, 2008 at 2:13 PM, Siegfried Goeschl > <[EMAIL PROTECTED]> wrote: >> +) I think that one or two commons developers will use the code and might >> provide additional support if needed > > I'm certainly one

Re: [exec] Proposal - Moving commons-exec from sandbox to proper

2008-06-17 Thread Siegfried Goeschl
You will be the primary support for OpenVMS ... :-) Siegfried Goeschl sebb wrote: On 17/06/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: On Tue, Jun 17, 2008 at 2:13 PM, Siegfried Goeschl <[EMAIL PROTECTED]> wrote: +) I think that one or two commons developers will use the code

Re: [exec] Proposal - Moving commons-exec from sandbox to proper

2008-06-17 Thread sebb
On 17/06/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > On Tue, Jun 17, 2008 at 2:13 PM, Siegfried Goeschl > > <[EMAIL PROTECTED]> wrote: > > > +) I think that one or two commons developers will use the code and might > > provide additional support if needed > > > I'm certainly one of those.

Re: [exec] Proposal - Moving commons-exec from sandbox to proper

2008-06-17 Thread Niklas Gustavsson
On Tue, Jun 17, 2008 at 2:13 PM, Siegfried Goeschl <[EMAIL PROTECTED]> wrote: > +) I think that one or two commons developers will use the code and might > provide additional support if needed I'm certainly one of those. /niklas ---

Re: [exec] Proposal - Moving commons-exec from sandbox to proper

2008-06-17 Thread Siegfried Goeschl
Good idea ... Siegfried Goeschl James Carman wrote: For stuff like MapUtils and StringUtils, I'd probably place a comment in there that these are not intended to be part of the public API and could change without warning. On Fri, Jun 13, 2008 at 9:46 AM, Siegfried Goeschl <[EMAIL PROTECTED]> w

Re: [exec] Proposal - Moving commons-exec from sandbox to proper

2008-06-17 Thread Siegfried Goeschl
Hi Niall, I only have the same response I wrote six months ago ... :-) +) I can't make any promises but commons-exec is small enough to be maintained in the small hours when the family is asleep +) I'm not expecting a huge user base - it's too late for that since many in-house libraries are al

Re: [compress] A few comments

2008-06-17 Thread Christian Grobmeier
> > I'll give it a look. I wanted to see how the Ar classes from jdeb could fit > into commons compress. Cool! Thorsten allready included some ArArchivers code, you may want to .take a look into: src\main\java\org\apache\commons\compress\archivers\ar

Re: [compress] A few comments

2008-06-17 Thread Emmanuel Bourg
Christian Grobmeier a écrit : I use cygwin and could check out with: $ git clone http://projects.grobmeier.de/compress-redesign.gitcompress-redesign I created a zip file for you: http://projects.grobmeier.de/compress-redesign-draft1.zip Thank you! I was about to clone it with Ubuntu on VMWare

Re: [compress] A few comments

2008-06-17 Thread Christian Grobmeier
Hi > Git is problematic for Windows. I tried to clone the repository with > msysgit but it failed with the following error : > >fatal: Couldn't find remote ref HEAD > I use cygwin and could check out with: $ git clone http://projects.grobmeier.de/compress-redesign.gitcompress-redesign I crea

Re: [compress] A few comments

2008-06-17 Thread Emmanuel Bourg
Christian Grobmeier a écrit : However, Thorsten and I currently develop a new and (hopefully) better implementation than that which is currently available. That implementation fixes some of the issues you mentioned. If you want to take a look at it, please check it out via GIT: http://projects.g

Re: [compress] A few comments

2008-06-17 Thread Christian Grobmeier
Hi Emmanuel, thanks for your comments below. They all make sense. However, Thorsten and I currently develop a new and (hopefully) better implementation than that which is currently available. That implementation fixes some of the issues you mentioned. If you want to take a look at it, please chec

[compress] A few comments

2008-06-17 Thread Emmanuel Bourg
I looked a bit at commons compress, I'd like to make a couple suggestions: - FileOutputStream and FileInputStream are used in several method signatures, but a simple OutputStream or InputStream would do the job. It's limiting the API to files only for no apparent reason. - I believe it would