RE: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread Jörg Schaible
Hi Martin, Oberhuber, Martin wrote: > Hi Rory, > > Thanks for your opinion -- but may I note that even if > It's a major releases, there may be (some|many) existing > Clients which are not broken even if they upgrade, > Depending on what APIs their client code currently uses. > > Breaking client

Re: [RESULT][VOTE] Release Commons SCXML 0.8

2008-05-20 Thread Rahul Akolkar
On 5/20/08, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > You probably know this, but in case you don't - because this is > SCXML's first m2 release (or the first release of a new groupId in the > m2 repo - i.e. "commons-scxml" in this case) you need to ping > [EMAIL PROTECTED] to ask them to

Re: [VOTE] Release Commons Chain 1.2 based on RC1

2008-05-20 Thread sebb
On 21/05/2008, Niall Pemberton <[EMAIL PROTECTED]> wrote: > I would like to do a bug fix release of Commons Chain - mainly to > release the fix for CHAIN-33[1] - which hit a Struts user recently > (see STR-3143[2]) - but there are a few other bug fixes as well > [1] http://issues.apache.org/jir

[Commons Wiki] Update of "CommonsOsgi" by NiallPemberton

2008-05-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The following page has been changed by NiallPemberton: http://wiki.apache.org/commons/CommonsOsgi -- || di

Re: [RESULT][VOTE] Release Commons SCXML 0.8

2008-05-20 Thread Niall Pemberton
On Mon, May 19, 2008 at 6:53 PM, Rahul Akolkar <[EMAIL PROTECTED]> wrote: > Adding my own vote, this vote passes with 6 +1s from: > > Phil Steitz > Oliver Heger > Sebb > Luc Maisonobe > Niall Pemberton > Rahul Akolkar > > Thanks for your time and all the feedback on the process as well. I'll > comp

[VOTE] Release Commons Chain 1.2 based on RC1

2008-05-20 Thread Niall Pemberton
I would like to do a bug fix release of Commons Chain - mainly to release the fix for CHAIN-33[1] - which hit a Struts user recently (see STR-3143[2]) - but there are a few other bug fixes as well [1] http://issues.apache.org/jira/browse/CHAIN-33 [2] https://issues.apache.org/struts/browse/STR-

RE: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread Oberhuber, Martin
Hi Rory, Thanks for your opinion -- but may I note that even if It's a major releases, there may be (some|many) existing Clients which are not broken even if they upgrade, Depending on what APIs their client code currently uses. Breaking clients for no good reason just isn't playing Nice with the

Re: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread Rory Winston
Can I just add, it's a major release (1.5 -> 2.0). Rory Winston wrote: This is totally irrelevant. It's called refactoring. Oberhuber, Martin wrote: I agree that I cannot see a strong argument for such a Breaking change. In general, binary backward compatibility For a lib with such a wide di

Re: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread Rory Winston
We've had this discussion already (at great length). It's not going to test/src. Niklas Gustavsson wrote: On Mon, May 19, 2008 at 7:36 PM, sebb <[EMAIL PROTECTED]> wrote: Would you be able to try the patches I just attached to NET-220? That should be enough to make the TFTPServer class th

Re: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread Rory Winston
This is totally irrelevant. It's called refactoring. Oberhuber, Martin wrote: I agree that I cannot see a strong argument for such a Breaking change. In general, binary backward compatibility For a lib with such a wide distribution should be maintained If there are no strong arguments against m

Re: [NET] Tabs and spaces

2008-05-20 Thread Dennis Lundberg
sebb wrote: On 20/05/2008, Dennis Lundberg <[EMAIL PROTECTED]> wrote: Dare I suggest that we start working on a Commons wide code style document? I'm willing to put in time setting up a Checkstyle configuration and an IDEA template, for whatever style we decide upon. What style we should cho

Re: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread sebb
On 20/05/2008, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > On Mon, May 19, 2008 at 7:36 PM, sebb <[EMAIL PROTECTED]> wrote: > > Would you be able to try the patches I just attached to NET-220? > > > > That should be enough to make the TFTPServer class threadsafe, and may > > address the shut

Re: [NET] Tabs and spaces

2008-05-20 Thread Rahul Akolkar
On 5/20/08, sebb <[EMAIL PROTECTED]> wrote: > On 20/05/2008, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > > Dare I suggest that we start working on a Commons wide code style document? > > > > I'm willing to put in time setting up a Checkstyle configuration and an > > IDEA template, for whateve

Re: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread Niklas Gustavsson
On Mon, May 19, 2008 at 7:36 PM, sebb <[EMAIL PROTECTED]> wrote: > Would you be able to try the patches I just attached to NET-220? > > That should be enough to make the TFTPServer class threadsafe, and may > address the shutdown problem. Didn't help with the issue I'm seeing. When on the topic o

Re: [NET] Tabs and spaces

2008-05-20 Thread Julius Davies
Tabs make the baby Jesus cry. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [NET] Tabs and spaces

2008-05-20 Thread sebb
On 20/05/2008, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > Dare I suggest that we start working on a Commons wide code style document? > > I'm willing to put in time setting up a Checkstyle configuration and an > IDEA template, for whatever style we decide upon. > > What style we should choose?

Re: [NET] Tabs and spaces

2008-05-20 Thread Dennis Lundberg
Dare I suggest that we start working on a Commons wide code style document? I'm willing to put in time setting up a Checkstyle configuration and an IDEA template, for whatever style we decide upon. What style we should choose? I don't really care that much, but like sebb I'm allergic to tabs

Re: [NET] Tabs and spaces

2008-05-20 Thread Rahul Akolkar
On 5/20/08, sebb <[EMAIL PROTECTED]> wrote: > On 20/05/2008, Oberhuber, Martin <[EMAIL PROTECTED]> wrote: > > > > Is there any guideline on tabs vs spaces in Commons? > > Dunno ... my view is that tabs are nothing but trouble, and should > never be used for formatting new code. > There is at

Re: [NET] Tabs and spaces

2008-05-20 Thread Niall Pemberton
On Tue, May 20, 2008 at 8:03 PM, sebb <[EMAIL PROTECTED]> wrote: > On 20/05/2008, Oberhuber, Martin <[EMAIL PROTECTED]> wrote: >> >> Is there any guideline on tabs vs spaces in Commons? > > Dunno ... my view is that tabs are nothing but trouble, and should > never be used for formatting new code.

Re: [NET] Tabs and spaces

2008-05-20 Thread sebb
On 20/05/2008, Oberhuber, Martin <[EMAIL PROTECTED]> wrote: > > Is there any guideline on tabs vs spaces in Commons? Dunno ... my view is that tabs are nothing but trouble, and should never be used for formatting new code. > Given that due to the Copyright Text Change we have > A diff on each

RE: [NET] Tabs and spaces

2008-05-20 Thread Oberhuber, Martin
Is there any guideline on tabs vs spaces in Commons? Given that due to the Copyright Text Change we have A diff on each and every file already, now might be A good time to do such a global cleanup, in order To simplify diffs / patches in upcoming bugfix Releases, and cross-porting patches betwee

RE: Commons Net 1.5 / 2.0 Releases

2008-05-20 Thread Oberhuber, Martin
I agree that I cannot see a strong argument for such a Breaking change. In general, binary backward compatibility For a lib with such a wide distribution should be maintained If there are no strong arguments against maintaining it. In this case, it looks like the various clients are small Enough

[chain] Releasing 1.2

2008-05-20 Thread Niall Pemberton
I'd like to release Chain 1.2 - mainly so that the fix CHAIN-33[1] is available in a release - this looks like its recently bitten a Struts user: https://issues.apache.org/struts/browse/STR-3143 I believe there have only been a few minor changes since the last release - but I will review properly

[Commons Wiki] Update of "CLI" by skolima

2008-05-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Commons Wiki" for change notification. The following page has been changed by skolima: http://wiki.apache.org/commons/CLI The comment on the change is: there is a default shallow copy in .Net! -