bradh352 commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2936957384
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -596,118 +845,196 @@ func resourceCloudStackNetworkACLRuleRead(d
*schema.ResourceDat
bhouse-nexthop commented on PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#issuecomment-4063323033
@vishesh92 looks like I had broken the legacy "ports" handling and didn't
know it because it was missing test cases. I've corrected that and added test
cases
Copilot commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2936975512
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -232,6 +481,30 @@ func resourceCloudStackNetworkACLRuleCreate(d
*schema.ResourceData,
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2937149988
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -300,17 +576,17 @@ func createNetworkACLRules(d *schema.ResourceData, meta
int
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2937150293
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -232,6 +481,30 @@ func resourceCloudStackNetworkACLRuleCreate(d
*schema.Resour
bhouse-nexthop commented on PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#issuecomment-4063634114
@vishesh92 looks like those latest copilot suggestions were legit as well.
Sorry about all the churn here, all the deprecated paths make it pretty complex
and
bhouse-nexthop commented on PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#issuecomment-4063084598
@vishesh92 please re-request copilot review. I found an issue with
managed=true not being honored with the new ruleset method, the latest commit
should fix t
Copilot commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2936808107
##
website/docs/r/network_acl_rule.html.markdown:
##
@@ -166,15 +236,15 @@ The `rule` block supports:
* `icmp_code` - (Optional) The ICMP code to
Copilot commented on code in PR #287:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/287#discussion_r2938400197
##
cloudstack/provider_test.go:
##
@@ -145,3 +146,42 @@ func testAccPreCheck(t *testing.T) {
t.Fatal("CLOUDSTACK_SECRET_KEY must be
