vishesh92 commented on code in PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#discussion_r2910106625
##
cloudstack/resource_cloudstack_disk_offering.go:
##
@@ -72,8 +73,59 @@ func resourceCloudStackDiskOfferingCreate(d
*schema.ResourceData, meta
vishesh92 commented on code in PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#discussion_r2910114454
##
cloudstack/resource_cloudstack_account.go:
##
@@ -37,26 +37,32 @@ func resourceCloudStackAccount() *schema.Resource {
vishesh92 commented on code in PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#discussion_r2910106625
##
cloudstack/resource_cloudstack_disk_offering.go:
##
@@ -72,8 +73,59 @@ func resourceCloudStackDiskOfferingCreate(d
*schema.ResourceData, meta
Copilot commented on code in PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#discussion_r2910122910
##
cloudstack/resource_cloudstack_disk_offering.go:
##
@@ -72,8 +73,59 @@ func resourceCloudStackDiskOfferingCreate(d
*schema.ResourceData, meta i
vishesh92 commented on code in PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#discussion_r2910145356
##
tests/comprehensive/versions.tf:
##
@@ -0,0 +1,9 @@
+terraform {
+ required_providers {
+cloudstack = {
+ source = "local/cloudstac
vishesh92 commented on code in PR #199:
URL:
https://github.com/apache/cloudstack-cloudmonkey/pull/199#discussion_r2910663269
##
vendor/golang.org/x/text/LICENSE:
##
Review Comment:
This is not an issue as per https://issues.apache.org/jira/browse/LEGAL-718
--
This is
Copilot commented on code in PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#discussion_r2910254578
##
cloudstack/resource_cloudstack_instance.go:
##
@@ -516,6 +541,11 @@ func resourceCloudStackInstanceRead(d
*schema.ResourceData, meta interface{
vishesh92 commented on PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#issuecomment-4029736425
@bhouse-nexthop can you check Copilot's comments? I have started the
acceptance tests for this PR.
--
This is an automated message from the Apache Git Service.
To
Copilot commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2910363546
##
cloudstack/resource_cloudstack_network.go:
##
@@ -471,3 +536,61 @@ func parseCIDR(d *schema.ResourceData, specifyiprange
bool) (map[string]stri
Copilot commented on code in PR #283:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/283#discussion_r2910362091
##
website/docs/r/private_gateway.html.markdown:
##
@@ -51,6 +65,11 @@ The following arguments are supported:
* `vpc_id` - (Required) The VPC ID i
Copilot commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2910363620
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -596,87 +843,108 @@ func resourceCloudStackNetworkACLRuleRead(d
*schema.ResourceData,
Copilot commented on code in PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#discussion_r2910366844
##
cloudstack/resource_cloudstack_static_route.go:
##
@@ -58,11 +75,20 @@ func resourceCloudStackStaticRouteCreate(d
*schema.ResourceData, meta in
weizhouapache commented on code in PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#discussion_r2910983358
##
cloudstack/provider_test.go:
##
@@ -145,3 +148,50 @@ func testAccPreCheck(t *testing.T) {
t.Fatal("CLOUDSTACK_SECRET_KEY m
vishesh92 commented on code in PR #268:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/268#discussion_r2910928649
##
cloudstack/resource_cloudstack_instance.go:
##
@@ -249,6 +249,12 @@ func resourceCloudStackInstance() *schema.Resource {
vishesh92 commented on code in PR #262:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/262#discussion_r2910994084
##
cloudstack/resource_cloudstack_security_group.go:
##
@@ -51,7 +51,20 @@ func resourceCloudStackSecurityGroup() *schema.Resource {
bhouse-nexthop commented on code in PR #283:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/283#discussion_r2911088574
##
website/docs/r/private_gateway.html.markdown:
##
@@ -51,6 +65,11 @@ The following arguments are supported:
* `vpc_id` - (Required) The V
bradh352 commented on code in PR #283:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/283#discussion_r2911085298
##
cloudstack/resource_cloudstack_private_gateway.go:
##
@@ -85,6 +85,12 @@ func resourceCloudStackPrivateGateway() *schema.Resource {
vishesh92 commented on PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#issuecomment-4030533291
@bhouse-nexthop Thanks for the PR. Can you check the comments on the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
Copilot commented on code in PR #262:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/262#discussion_r2911014084
##
cloudstack/resources.go:
##
@@ -162,6 +162,19 @@ func setProjectid(p cloudstack.ProjectIDSetter, cs
*cloudstack.CloudStackClient,
retur
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912482625
##
cloudstack/resource_cloudstack_network.go:
##
@@ -471,3 +536,61 @@ func parseCIDR(d *schema.ResourceData, specifyiprange
bool) (map[stri
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912474910
##
cloudstack/resource_cloudstack_network.go:
##
@@ -471,3 +536,61 @@ func parseCIDR(d *schema.ResourceData, specifyiprange
bool) (map[stri
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912488478
##
cloudstack/resource_cloudstack_network.go:
##
@@ -306,6 +358,19 @@ func resourceCloudStackNetworkRead(d *schema.ResourceData,
meta inter
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912495755
##
cloudstack/resource_cloudstack_network_test.go:
##
@@ -165,6 +172,75 @@ func TestAccCloudStackNetwork_importProject(t *testing.T) {
bhouse-nexthop commented on PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#issuecomment-4032196908
@vishesh92 I addressed all Copilot review comments, can you please
re-request review to make sure it looks ok?
--
This is an automated message from the Apach
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2912337052
##
website/docs/r/network_acl_rule.html.markdown:
##
@@ -127,6 +127,61 @@ resource "cloudstack_network_acl_rule" "web_server" {
descrip
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2912359049
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -187,6 +188,75 @@ func resourceCloudStackNetworkACLRule() *schema.Resource {
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2912363498
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -202,6 +272,159 @@ func resourceCloudStackNetworkACLRule() *schema.Resource {
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2912366996
##
cloudstack/resource_cloudstack_network_acl_rule.go:
##
@@ -596,87 +843,108 @@ func resourceCloudStackNetworkACLRuleRead(d
*schema.Resour
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2912370036
##
cloudstack/resource_cloudstack_network_acl_rule_test.go:
##
@@ -251,6 +252,369 @@ func testAccCheckCloudStackNetworkACLRuleDestroy(s
*te
bhouse-nexthop commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2912337052
##
website/docs/r/network_acl_rule.html.markdown:
##
@@ -127,6 +127,61 @@ resource "cloudstack_network_acl_rule" "web_server" {
descrip
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912795485
##
cloudstack/resource_cloudstack_network.go:
##
@@ -471,3 +530,88 @@ func parseCIDR(d *schema.ResourceData, specifyiprange
bool) (map[stri
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912789902
##
cloudstack/resource_cloudstack_network_unit_test.go:
##
@@ -0,0 +1,236 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912793847
##
cloudstack/resource_cloudstack_network.go:
##
@@ -471,3 +530,88 @@ func parseCIDR(d *schema.ResourceData, specifyiprange
bool) (map[stri
bhouse-nexthop commented on PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#issuecomment-4032589289
@vishesh92 ok, addressed those additional comments. Hopefully everything is
clean this time!
--
This is an automated message from the Apache Git Service.
To
bhouse-nexthop commented on code in PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#discussion_r2912190411
##
cloudstack/resource_cloudstack_instance.go:
##
@@ -516,6 +541,11 @@ func resourceCloudStackInstanceRead(d
*schema.ResourceData, meta int
bhouse-nexthop commented on code in PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#discussion_r2912193295
##
website/docs/r/network_acl.html.markdown:
##
@@ -30,7 +53,8 @@ The following arguments are supported:
new resource to be created.
bhouse-nexthop commented on code in PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#discussion_r2912211762
##
cloudstack/resource_cloudstack_network_acl_test.go:
##
@@ -110,6 +133,19 @@ func testAccCheckCloudStackNetworkACLBasicAttributes(
bhouse-nexthop commented on PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#issuecomment-4031893922
> @bhouse-nexthop can you check Copilot's comments? I have started the
acceptance tests for this PR.
done, can you re-request copilot review to validate?
bhouse-nexthop commented on code in PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#discussion_r2912199921
##
website/docs/r/port_forward.html.markdown:
##
@@ -25,6 +27,38 @@ resource "cloudstack_port_forward" "default" {
}
```
+### Port Forwa
bhouse-nexthop commented on code in PR #280:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/280#discussion_r2912195429
##
website/docs/r/ipaddress.html.markdown:
##
@@ -35,7 +86,10 @@ The following arguments are supported:
acquired and associated. Changin
bhouse-nexthop commented on code in PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#discussion_r2912666781
##
cloudstack/provider_test.go:
##
@@ -145,3 +148,50 @@ func testAccPreCheck(t *testing.T) {
t.Fatal("CLOUDSTACK_SECRET_KEY
bhouse-nexthop commented on code in PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#discussion_r2912684102
##
cloudstack/resource_cloudstack_static_route_test.go:
##
@@ -42,6 +42,32 @@ func TestAccCloudStackStaticRoute_basic(t *testing.T) {
bhouse-nexthop commented on code in PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#discussion_r2912673192
##
website/docs/r/static_route.html.markdown:
##
@@ -12,22 +12,43 @@ Creates a static route for the given private gateway or VPC.
## Exam
bhouse-nexthop commented on code in PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#discussion_r2912710271
##
cloudstack/resource_cloudstack_static_route.go:
##
@@ -58,11 +75,20 @@ func resourceCloudStackStaticRouteCreate(d
*schema.ResourceData,
bhouse-nexthop commented on code in PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#discussion_r2912704880
##
cloudstack/resource_cloudstack_static_route.go:
##
@@ -42,9 +42,26 @@ func resourceCloudStackStaticRoute() *schema.Resource {
bhouse-nexthop commented on PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#issuecomment-4032484042
@vishesh92 all comments addressed, please re-request Copilot review.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
bhouse-nexthop commented on PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#issuecomment-4032061379
> @bhouse-nexthop Thanks for the PR. Can you check the comments on the PR?
Addressed all comments. Please re-run Copilot review.
--
This is an automat
bhouse-nexthop commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912467387
##
cloudstack/resource_cloudstack_network.go:
##
@@ -209,6 +236,31 @@ func resourceCloudStackNetworkCreate(d
*schema.ResourceData, meta int
bhouse-nexthop commented on code in PR #283:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/283#discussion_r2912556312
##
website/docs/r/private_gateway.html.markdown:
##
@@ -51,6 +65,11 @@ The following arguments are supported:
* `vpc_id` - (Required) The V
Copilot commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2912554605
##
cloudstack/resource_cloudstack_network.go:
##
@@ -471,3 +530,88 @@ func parseCIDR(d *schema.ResourceData, specifyiprange
bool) (map[string]stri
bhouse-nexthop commented on PR #283:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/283#issuecomment-4032257236
@vishesh92 code review comments addressed, please re-request from copilot
--
This is an automated message from the Apache Git Service.
To respond to the messa
Hi Daan and Team,
We have updated the PR and addressed all the comments provided.
Please feel free to reach out if you need any additional input or if
anything further is required from our side.
Regards,
Rajiv Jain
On Wed, Feb 18, 2026 at 1:37 PM Rajiv Jain <
connect.rajivjain.virtualizat...@gma
vishesh92 merged PR #286:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
vishesh92 commented on PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#issuecomment-4029581807
@kristofer-atlas We already have some tests here:
https://github.com/apache/cloudstack-terraform-provider/blob/main/cloudstack/resource_cloudstack_disk_test.go
vishesh92 commented on PR #284:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/284#issuecomment-4030463705
@bhouse-nexthop Can you check Copilot's comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
vishesh92 commented on code in PR #283:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/283#discussion_r2910896149
##
cloudstack/resource_cloudstack_private_gateway.go:
##
@@ -85,6 +85,12 @@ func resourceCloudStackPrivateGateway() *schema.Resource {
vishesh92 commented on code in PR #268:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/268#discussion_r2910920846
##
cloudstack/resource_cloudstack_disk.go:
##
@@ -92,13 +92,19 @@ func resourceCloudStackDisk() *schema.Resource {
Copilot commented on code in PR #282:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/282#discussion_r2914167224
##
cloudstack/resource_cloudstack_network.go:
##
@@ -78,13 +78,26 @@ func resourceCloudStackNetwork() *schema.Resource {
bhouse-nexthop opened a new pull request, #287:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/287
There's no reason to build and test EOL versions of Cloudstack, OpenTofu,
and Terraform. Also recent supported versions were being excluded.
This PR will also be used
kristofer-atlas commented on code in PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#discussion_r2914738909
##
tests/comprehensive/main.tf:
##
@@ -0,0 +1,330 @@
+# Test Infrastructure for CloudStack Terraform Provider Verification
+# This tests al
kristofer-atlas commented on code in PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#discussion_r2914737645
##
cloudstack/resource_cloudstack_domain.go:
##
@@ -89,9 +89,62 @@ func resourceCloudStackDomainCreate(d *schema.ResourceData,
meta interf
kristofer-atlas commented on PR #285:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/285#issuecomment-4034798410
@vishesh92, the intent of the tests was to be a sort of end-to-end test.
Removed for now. Hadn't noticed the tests you point to.
Wondering, though, whet
bhouse-nexthop commented on PR #287:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/287#issuecomment-4035701554
> @vishesh92 this will be needed to get clean tests for all the other PRs I
created. Interestingly it appears the 4.22.0.0 simulator has some bug I had to
disa
bradh352 commented on PR #287:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/287#issuecomment-4035698094
@vishesh92 this will be needed to get clean tests for all the other PRs I
created. Interestingly it appears the 4.22.0.0 simulator has some bug I had to
disable som
Copilot commented on code in PR #281:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/281#discussion_r2916230554
##
cloudstack/resource_cloudstack_network_acl_rule_test.go:
##
@@ -251,6 +254,375 @@ func testAccCheckCloudStackNetworkACLRuleDestroy(s
*terraform
vishesh92 commented on code in PR #283:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/283#discussion_r2916276314
##
cloudstack/resource_cloudstack_private_gateway.go:
##
@@ -85,6 +85,13 @@ func resourceCloudStackPrivateGateway() *schema.Resource {
66 matches
Mail list logo
