+1 to set dismiss_stale_reviews: false.
Best,
Dianjin Wang
On Fri, Jan 17, 2025 at 2:10 PM Ed Espino wrote:
> Hi Dianjin,
>
> Thank you for explaining the dismiss_stale_reviews option in the .asf.yaml
> file. Since we are running on GitHub, I believe we can leverage GitHub’s
> built-in capabil
Hi Dianjin,
Thank you for explaining the dismiss_stale_reviews option in the .asf.yaml
file. Since we are running on GitHub, I believe we can leverage GitHub’s
built-in capabilities to track changes and ensure a smooth review process.
GitHub automatically captures and displays all changes between
AFAIK, whether to allow dismissing the stale approval is configured in the
`.asf.yaml` file:
```
# Require new reviews when new commits are pushed
dismiss_stale_reviews: true
```
I'm open to this. If allowed not to dismiss the stale approval, the
committers who merge these commits
Sounds reasonable in some cases. Is it possible to add a special CI skip
cancel instruction if author don't want to cancel APPROVE?
On Thu, Jan 16, 2025 at 5:42 PM jiaqi.zhou wrote:
> Hi all,
>
>
> I personally have an idea: we should not cancel approve after PR has been
> updated.
>
>
> 1. Aft
Hi all,
I personally have an idea: we should not cancel approve after PR has been
updated.
1. After the reviewer approves the PR, the current PR may still need to be
rebased (do git rebase main or git merge main)
2. The approved PR will still run CI once to ensure that the current PR is
c
