Re: [VOTE] CEP-43: Apache Cassandra CREATE TABLE LIKE

2024-11-07 Thread guo Maxwell
Thank you everyone. If there is no other feedback, I feel that this vote has passed and CEP-43 is adopted. Bernardo Botella 于2024年11月6日周三 23:40写道: > +1 (nb) > > Thanks a lot Guo for addressing all the comments! > > On Nov 6, 2024, at 7:21 AM, Štefan Miklošovič > wrote: > > Having all cleared ou

Re: [VOTE] CEP-43: Apache Cassandra CREATE TABLE LIKE

2024-11-07 Thread Štefan Miklošovič
Hi Maxwell, any CEP in general requires more binding votes than 1 from myself. I advise you to wait a little bit longer until at least three binding votes accumulate. Regards On Thu, Nov 7, 2024 at 4:42 PM guo Maxwell wrote: > Thank you everyone. If there is no other feedback, I feel that thi

[DISCUSS] GoCQL sub modules vs packages

2024-11-07 Thread João Reis
The goal of CASSGO-21 [1] is to move HostPoolHostPolicy out of the main package so that users don't have to download the github.com/hailocab/go-hostpool dependency if they are not using this specific policy. The question is whether we want to move this policy to a separate module or if it is enough

Re: [VOTE] CEP-43: Apache Cassandra CREATE TABLE LIKE

2024-11-07 Thread Dinesh Joshi
Maxwell, here's the documentation for project governance for reference - https://cwiki.apache.org/confluence/display/CASSANDRA/Cassandra+Project+Governance Like Stefan said, please wait until more binding +1s come in. I'm +1 on the CEP. thanks, Dinesh On Thu, Nov 7, 2024 at 7:51 AM Štefan Mik

[DISCUSS] Go version in go.mod (GoCQL)

2024-11-07 Thread João Reis
The Go version that is specified in "go.mod" is 1.13 but this is out of date, 1.17 is required to build GoCQL at the moment. Bumping the version on this file to 1.17 needs to be done regardless but should we bump this version to the minimum Go version that GoCQL officially supports or the one that

Re: [VOTE] CEP-43: Apache Cassandra CREATE TABLE LIKE

2024-11-07 Thread guo Maxwell
Thanks Stefan and Dinesh. Let's wait a little longer. Dinesh Joshi 于2024年11月7日周四 23:56写道: > Maxwell, here's the documentation for project governance for reference - > https://cwiki.apache.org/confluence/display/CASSANDRA/Cassandra+Project+Governance > > Like Stefan said, please wait until more

Re: [DISCUSS] Introduce CREATE TABLE LIKE grammer

2024-11-07 Thread Dave Herrington
I wanted to weigh in on the options handling. Being able to override table options like compaction strategy would be valuable for use cases when we are evaluating side-by-side the performance of different compaction settings. We can always do ALTER TABLE after the CREATE TABLE LIKE, but it would

Re: [DISCUSS] Introduce CREATE TABLE LIKE grammer

2024-11-07 Thread Dave Herrington
👍 On Thu, Nov 7, 2024 at 10:58 PM guo Maxwell wrote: > Thank you very much for your careful observation. I have corrected it, it > is out of date, just remove the OPTIONS keyword. > > > Dave Herrington 于2024年11月8日周五 14:52写道: > >> I wanted to weigh in on the options handling. >> >> Being able to

Re: [DISCUSS] Introduce CREATE TABLE LIKE grammer

2024-11-07 Thread guo Maxwell
Thank you very much for your careful observation. I have corrected it, it is out of date, just remove the OPTIONS keyword. Dave Herrington 于2024年11月8日周五 14:52写道: > I wanted to weigh in on the options handling. > > Being able to override table options like compaction strategy would be > valuable