Re: [Discuss] Repair inside C*

2024-10-30 Thread Mick Semb Wever
Thanks Jaydeep. I've exhausted my lines on enquiry and am happy that thought has gone into them. > On top of the above list, here is my recommendation (this is just a pure > thought only and subject to change depending on how all the community > members see it): > >- Nov-Dec: We can definit

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread Benjamin Lerer
I recently faced some var usage in the CQL layer part where it was making the code pretty hard to understand. I am in favor of prohibiting it. Le mar. 29 oct. 2024 à 20:32, Caleb Rackliffe a écrit : > Josh's example of "good" usage seems defensible, because the declared type > is already obfusca

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread Aleksey Yeshchenko
Allow in tests, forbid elsewhere for now would be my vote. > On 30 Oct 2024, at 11:45, Štefan Miklošovič wrote: > > against vars: > > Benjamin > Stefan > Benedict > Yifan > > somewhere in the middle: > > Dinesh > > Caleb +1 in tests and +0 in prod code. > David - against flat out banning, li

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread Štefan Miklošovič
https://issues.apache.org/jira/browse/CASSANDRA-20038 On Wed, Oct 30, 2024 at 2:40 PM Brandon Williams wrote: > Allow in tests, forbid elsewhere is my vote and simple to implement. > > Kind Regards, > Brandon > > On Wed, Oct 30, 2024 at 6:46 AM Štefan Miklošovič > wrote: > > > > against vars: >

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread Brandon Williams
Allow in tests, forbid elsewhere is my vote and simple to implement. Kind Regards, Brandon On Wed, Oct 30, 2024 at 6:46 AM Štefan Miklošovič wrote: > > against vars: > > Benjamin > Stefan > Benedict > Yifan > > somewhere in the middle: > > Dinesh > > Caleb +1 in tests and +0 in prod code. > Davi

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread Jacek Lewandowski
+1 for allow in tests and ban in production code. - - -- --- - - Jacek Lewandowski śr., 30 paź 2024 o 17:37 David Capwell napisał(a): > I am fine with allow in tests ban in src > > On Oct 30, 2024, at 7:16 AM, Štefan Miklošovič > wrote: > > https://issues.apache.or

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread David Capwell
I am fine with allow in tests ban in src > On Oct 30, 2024, at 7:16 AM, Štefan Miklošovič wrote: > > https://issues.apache.org/jira/browse/CASSANDRA-20038 > > On Wed, Oct 30, 2024 at 2:40 PM Brandon Williams > wrote: >> Allow in tests, forbid elsewhere is my vote and s

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread Francisco Guerrero
Yeah, I'm also in favor of disallowing usage of var in production code. On 2024/10/30 16:43:06 Jacek Lewandowski wrote: > +1 for allow in tests and ban in production code. > > > > > - - -- --- - - > Jacek Lewandowski > > > śr., 30 paź 2024 o 17:37 David Capwell napi

Re: [Discuss] Repair inside C*

2024-10-30 Thread Jaydeep Chovatia
Thanks for the kind words, Mick! Jaydeep On Wed, Oct 30, 2024 at 1:35 AM Mick Semb Wever wrote: > Thanks Jaydeep. I've exhausted my lines on enquiry and am happy that > thought has gone into them. > > > >> On top of the above list, here is my recommendation (this is just a pure >> thought only

Re: [DISCUSS] Usage of "var" instead of types in the code

2024-10-30 Thread Štefan Miklošovič
against vars: Benjamin Stefan Benedict Yifan somewhere in the middle: Dinesh Caleb +1 in tests and +0 in prod code. David - against flat out banning, limiting it just for some places Josh prod / test on/off switch. for: Jon Correct me if I am wrong and I have "miscategorized" somebody. >Fr