Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-12-22 Thread Maxim Muzafarov
Hello everyone, have a great vacation and happy holidays to all! I've completed a small research about how the classe's import order rule are spread in the Apache projects. Some of the projects don't have any restrictions over the imports even if they are using the checkstyle configuration. The o

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-12-22 Thread Benedict
I like 3 or 4. We need to be sure we have a way of deactivating the check with code comments tho, as Java 8 has some bug with import order that can rarely break compilation, so we need to have some mechanism for permitting a different import order. Did we decide any changes to star imports?

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-12-22 Thread Miklosovic, Stefan
4 I would like to avoid star imports in general. Having them explicitly enumerated seems to be better, it can not happen we use some import wrongly (by accident). There is rational behind this here (1). This check can be configured in such a way that star imports could be possible on some pack

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-12-22 Thread Derek Chen-Becker
I vote for #4. I've always used the convention of having stdlib stuff first, external stuff second, and same-project imports last. I guess increasing order of specificity? Happy Holidays! Derek On Thu, Dec 22, 2022 at 7:52 AM Maxim Muzafarov wrote: > > Hello everyone, have a great vacation and

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-12-22 Thread David Capwell
Im good with 3 and 4. > On Dec 22, 2022, at 10:41 AM, Derek Chen-Becker wrote: > > I vote for #4. I've always used the convention of having stdlib stuff > first, external stuff second, and same-project imports last. I guess > increasing order of specificity? > > Happy Holidays! > > Derek > >

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-12-22 Thread Mick Semb Wever
> > > 3. Total 5 groups, 2968 files to change > > ``` > org.apache.cassandra.* > [blank line] > java.* > [blank line] > javax.* > [blank line] > all other imports > [blank line] > static all other imports > ``` > 3, then 5. There's lots under com.*, net.*, org.* that is essentially the same as "a