Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread bened...@apache.org
Hi Jeremiah, My personal view is that work to modularise the codebase should be tied to specific use cases. If improved testing is the purpose of this work, I think it would help to include those improved tests that you plan to support as goals for the CEP. If on the other hand some of this wo

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread Henrik Ingo
Hi Benedict This CEP is a bundle of APIs arising out of our recent work to re-architect Cassandra into a more cloud native architecture. What our product marketing has chosen to call "Serverless" is a variant of Cassandra where we have separated compute from storage (coordinator vs data node), use

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread David Capwell
I am cool with pluggability and making things easier to test; my main comment for this work is that we must also define semantics around the APIs and can't just create interfaces. Simple example of this is CASSANDRA-17058 (linked from the CEP

Re: [DISCUSS] CASSANDRA-15234

2021-10-25 Thread Ekaterina Dimitrova
Thank you Benedict. Considering there were no objections I am closing the discussion and getting back to work on the ticket itself. Thank you all. Have a great week ahead. On Wed, 20 Oct 2021 at 18:06, bened...@apache.org wrote: > Thanks for moving this forwards Ekaterina. > > I think what we p

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread bened...@apache.org
Thanks Henrik for the additional context. I’m not personally a fan of modularity only for modularity’s sake. Everything in software is a balancing act of competing priorities, and while pluggability supports certain use cases it can slow down development or prevent deeper integrations by preven

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread David Capwell
> > ... I just think it is important to make a decision for each refactor > based on the merits and goals in question. If the justification is improved > testing, then testing should be a core goal of the CEP. If it’s enabling a > feature to be upstreamed later, I personally would prefer to tie the

Cassandra project biweekly status update 2021-10-25

2021-10-25 Thread Joshua McKenzie
I can't believe it's been two weeks already. [New contributors getting started] As a new contributor we recommend starting in one of two places: Failing tests, or what we call "lhf" (low hanging fruit). Query for failing tests: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496&q

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread Jeremiah D Jordan
As Henrik said we have been refactoring access to these different internal APIs as part of some larger work. For this CEP we pulled together a bunch of the smaller ones into one place, similar to the refactoring proposed in CEP-10, as we felt doing many small CEPs, one per module, would be less