Re: [DISCUSS] Implementing code quality principles, and rules (was: Code quality, principles and rules)

2017-03-28 Thread Josh McKenzie
Hold on now - there's no reason to throw the baby out with the bathwater on this. Code coverage on it's own is admittedly a questionable metric, but bad metrics are better than *no* metrics if taken with context. Most code coverage tools will allow you to drill down to the granularity we'd need to

Re: [DISCUSS] Implementing code quality principles, and rules (was: Code quality, principles and rules)

2017-03-28 Thread Jason Brown
re: code coverage (this could become it's own thread, and probably should) As somebody working on a new large feature (CASSANDRA-8457), I have a few thoughts/observations about code coverage. As a preface, though, I'll point out that we have jacoco (http://www.jacoco.org/jacoco/trunk/index.html) a

Re: [DISCUSS] Implementing code quality principles, and rules (was: Code quality, principles and rules)

2017-03-28 Thread sankalp kohli
If the code coverage goes down or do not go above the required cutoff due to adding toString or getter setter like functionality, can we make it a process to explain the reason in the JIRA before committing it? Regarding changes in hard to unit tests parts of the code, can we make it a process to

Re: [DISCUSS] Implementing code quality principles, and rules (was: Code quality, principles and rules)

2017-03-28 Thread Ariel Weisberg
Hi, Code coverage: I value code coverage as part of the review and development process. As a project wide target I think it's not as high value, but having a standard encourages people to take the time to use the tools and that's a healthy side effect. Code coverage is a measure of code execution

Proposal: push TravisCI and CircleCI yaml files into the active branches

2017-03-28 Thread Jeff Jirsa
To further our recent conversations on testing, I've opened the following JIRA: https://issues.apache.org/jira/browse/CASSANDRA-13388 This should allow us to do SOME amount of automated testing for developers without jumping through a ton of hoops. If the free plans prove to be insufficient, we c

API for Cassandra CQL

2017-03-28 Thread Ramesh Mani
Hello Cassandra team members, I am looking for API via which I can get the CQL session query as string? Is there a way I can get the Query executed by the users via API Thanks, Ramesh