We can spend hours arguing about assert vs exceptions. I have seen it
happen in every company I worked for.
Overall, based on the patches I have reviewed, it seems to me that in
general people are using them only has internal safety checks.
Unfortunatly, the code change and we can miss things.
If a
As an aside, C* for some reason heavily uses asserts in unit tests,
which adds to the "can't see the forest for the trees" problem. I see no
reason for that. they should all be moved over to junit asserts.
On 09/22/2016 03:52 AM, Benjamin Lerer wrote:
We can spend hours arguing about assert v
I fully agree.
On Thu, Sep 22, 2016 at 11:57 AM, Dave Brosius
wrote:
> As an aside, C* for some reason heavily uses asserts in unit tests, which
> adds to the "can't see the forest for the trees" problem. I see no reason
> for that. they should all be moved over to junit asserts.
>
>
>
> On 09/2
Hi All,
cassandra-3.9:
===
testall: 5 failures
org.apache.cassandra.cql3.ViewFilteringTest
.testMVCreationSelectRestrictions
org.apache.cassandra.cql3.ViewFilteringTest
.testClusteringKeyFilteringRestrictions
org.apache.cassandra.cql3.ViewTest
.
Yes obviously we do not need to go in and replace them all at once. Some
rough guidance/general consensus should be in place, because we are
violating the standard usage:
https://docs.oracle.com/javase/8/docs/technotes/guides/language/assert.html
Do *not* use assertions for argument checking in p
Hi Nate,
Good we have these guidelines. I have seen several parts of
the code which were added without any tests over the years. We should at
the minimum make it mandatory to add tests specially when adding major
features to the code base.
Thanks,
Sankalp
On Wed, Sep 21, 2016 at 3:27
Folks,
Yesterday, I officially stepped into the role of PMC chair for Apache
Cassandra.
It is important to me that the first email I send in this capacity be
a simple and sincere thank you for all the effort Jonathan Ellis has
put into this position.
Best regards,
-Nate
[Moved from PMC as there is nothing really private involved]
DataStax has graciously offered to contribute cassandra-dtest [0] to
the project.
There were, however, two issues noted by Jonathan when he presented
the offer to the PMC:
1. dtest mixes tests for many cassandra versions together in a
