Re: another refactoring proposal

2010-09-19 Thread Morten Wegelbye Nissen
On 15-09-2010 19:16, Amol Deshpande wrote: Hi, Would there be any objections to the following code refactoring ? 1. Create a CassandraServerExceptionFactory class that returns various exceptions that can be thrown by StorageProxy instead of thrift exceptions. 2. Create a CassandraServerConsist

Re: Randomly read repair?

2010-09-19 Thread Jonathan Ellis
You're right, the simplest fix here is to just always do the re-read in the strong path. Done in r998720. (IMO the "right" thing is more complicated -- we shouldn't send requests to _all_ the replicas on the _first_ read with CL.QUORUM, except as dictated by randomlyReadRepair.) On Sat, Sep 18,

Re: Randomly read repair?

2010-09-19 Thread Zhu Han
> > (IMO the "right" thing is more complicated -- we shouldn't send > requests to _all_ the replicas on the _first_ read with CL.QUORUM, > except as dictated by randomlyReadRepair.) > > I agree with you. But which replicas to send requests depends on the replication strategy... Only the nearest nod

Re: Randomly read repair?

2010-09-19 Thread Jonathan Ellis
On Sun, Sep 19, 2010 at 8:58 PM, Zhu Han wrote: > BTW, which version of cassandra was the randomly repair feature firstly > implemented? 0.7 beta? yes -- Jonathan Ellis Project Chair, Apache Cassandra co-founder of Riptano, the source for professional Cassandra support http://riptano.com

how to gen java interface source code in cassandra0.6.5?

2010-09-19 Thread summer.xie
Hi, I run "thrift -o thrift/ --gen java cassandra.thrift" to generate the java code. But I can't not complie the source code. Thrift version is 0.4.0-dev, My generated code are different from the code from svn. Why? How to generate the interface source code to "apache-cassandra-0

Re: how to gen java interface source code in cassandra0.6.5?

2010-09-19 Thread Jonathan Ellis
thrift generated code changes frequently. check out the same revision of the thrift compiler that the jar in lib/ uses. On Mon, Sep 20, 2010 at 1:20 AM, summer.xie wrote: > Hi, > > I run "thrift -o thrift/ --gen java cassandra.thrift"  to generate the java > code.  But I can't not complie the so