It also means that problems that are introduced are bisectable, which
given these changes would be a real benefit.
It also means if the process doesn't go well, you won't hate reviewers
for life.
On 2014-06-03 17:24, Dave Brosius wrote:
This is a relatively stupid comment, but i'm good at
> On 4 Jun 2014, at 7:24 am, Dave Brosius wrote:
>
> The solution to several of these issues is,
>
> Refactor 1 singleton use case, and post a patch.
+1 do it slowly
-1 for adding a dependency on a dependency injection framework. It's not
strictly needed if your goal is for removing singlet
This is a relatively stupid comment, but i'm good at that so here goes.
The solution to several of these issues is,
Refactor 1 singleton use case, and post a patch.
1) less classes are involved
2) the review is more likely to be understood by one person
3) less chance for regression
4) marginal
> (services not using other services)
meant services not used by other services
Simon Chemouil racontait le 03/06/2014 21:20:
> Gary Dusbabek racontait le 03/06/2014 19:59:
>> This has come up before. Let's face it, removing the singletons is a
>> tempting proposition.
>>
>> Several of us have bee
Gary Dusbabek racontait le 03/06/2014 19:59:
> This has come up before. Let's face it, removing the singletons is a
> tempting proposition.
>
> Several of us have been down the path of trying to do it.
>
> At the end of the day, here's what you'd end up with (absolutely best case):
>
> 1. Modify
Brandon Williams racontait le 03/06/2014 20:00:
> Relevant: https://issues.apache.org/jira/browse/CASSANDRA-6881
Thanks for the pointer, couldn't find that issue.
> On Tue, Jun 3, 2014 at 12:59 PM, Gary Dusbabek wrote:
>
>> On Tue, Jun 3, 2014 at 3:52 AM, Simon Chemouil
>> wrote:
>>
>>> Hi,
There was some hope started in CASSANDRA-6881 - see some of the later comments:
https://issues.apache.org/jira/browse/CASSANDRA-6881
On 4 Jun 2014, at 04:04, Brian O'Neill wrote:
>
> Interesting proposition. We¹ve embedded Cassandra a few times, so I¹d be
> interested in an approach that make
Interesting proposition. We¹ve embedded Cassandra a few times, so I¹d be
interested in an approach that makes that easier.
Is there a way to do it incrementally? Introduce the injection framework,
and convert a few classes (those required for startup), then slowly
convert the remainder?
peanut
Relevant: https://issues.apache.org/jira/browse/CASSANDRA-6881
On Tue, Jun 3, 2014 at 12:59 PM, Gary Dusbabek wrote:
> On Tue, Jun 3, 2014 at 3:52 AM, Simon Chemouil
> wrote:
>
> > Hi,
> >
> > I'm new to Cassandra and felt like exploring and hacking on the code. I
> > was surprised to see the
On Tue, Jun 3, 2014 at 3:52 AM, Simon Chemouil wrote:
> Hi,
>
> I'm new to Cassandra and felt like exploring and hacking on the code. I
> was surprised to see the usage of so many mutable/global state statics
> all over the service package (basically global variables/singletons).
>
> While I unde
Hi,
I'm new to Cassandra and felt like exploring and hacking on the code. I
was surprised to see the usage of so many mutable/global state statics
all over the service package (basically global variables/singletons).
While I understand it can be practical to work with singletons, and that
in any
11 matches
Mail list logo
