Re: [VOTE] Release Apache Cassandra 4.1.6 - take 2

With five +1 (four binding) and no -1, the vote passes. I'll work on getting the release published. On Wed, Aug 14, 2024 at 11:54 AM Brandon Williams wrote: > > Proposing the test build of Cassandra 4.1.6 for release. > > sha1: 790de1079811278a2b431c2ced7c7ea02d290a25 > Git: https://github.com/a

Re: [VOTE] Release Apache Cassandra 4.1.6 - take 2

. > The vote will be open for 72 hours (longer if needed). Everyone who > has tested the build is invited to vote. Votes by PMC members are > considered binding. A vote passes if there are at least three binding > +1s and no -1's. > +1 Checked - signing correct - checksums are correct - so

Re: [VOTE] Release Apache Cassandra 4.1.6 - take 2

+1 On Wed, Aug 14, 2024 at 11:54 AM Brandon Williams wrote: > > Proposing the test build of Cassandra 4.1.6 for release. > > sha1: 790de1079811278a2b431c2ced7c7ea02d290a25 > Git: https://github.com/apache/cassandra/tree/4.1.6-tentative > Maven Artifacts: > https://repository.apache.org/content/re

Re: [VOTE] Release Apache Cassandra 4.1.6 - take 2

gt; > *Reply-To*: dev@cassandra.apache.org > *To*: dev@cassandra.apache.org > *Subject*: Re: [VOTE] Release Apache Cassandra 4.1.6 - take 2 > *Date*: Wed, 14 Aug 2024 11:07:54 -0700 > > +1 > > On Wed, Aug 14, 2024 at 9:55 AM Brandon Williams < > brandonwilli...@apache.org>

Re: [VOTE] Release Apache Cassandra 4.1.6 - take 2

+1 (nb) -Original Message- From: Jon Haddad mailto:jon%20haddad%20%3c...@jonhaddad.com%3e>> Reply-To: dev@cassandra.apache.org<mailto:dev@cassandra.apache.org> To: dev@cassandra.apache.org<mailto:dev@cassandra.apache.org> Subject: Re: [VOTE] Release Apache Cassandra 4

Re: [VOTE] Release Apache Cassandra 4.1.6 - take 2

+1 On Wed, Aug 14, 2024 at 9:55 AM Brandon Williams wrote: > Proposing the test build of Cassandra 4.1.6 for release. > > sha1: 790de1079811278a2b431c2ced7c7ea02d290a25 > Git: https://github.com/apache/cassandra/tree/4.1.6-tentative > Maven Artifacts: > > https://repository.apache.org/content/re

Re: [VOTE] Release Apache Cassandra 4.1.6

gt; > and prioritize requests. I would say that the QueryHandler interface >> > together with the custom payload feature in the native protocol is a >> > powerful combination and I would not be surprised if this is used more >> > then you might expect. >> > >> > -O

Re: [VOTE] Release Apache Cassandra 4.1.6

ure in the native protocol > is a powerful combination and I would not be surprised if this is used more > then you might expect. > > > > -Original Message- > > From: J. D. Jordan > > Reply-To: dev@cassandra.apache.org > > To: dev@cassandra.apache.org &g

Re: [VOTE] Release Apache Cassandra 4.1.6

-- > From: J. D. Jordan > Reply-To: dev@cassandra.apache.org > To: dev@cassandra.apache.org > Subject: Re: [VOTE] Release Apache Cassandra 4.1.6 > Date: Thu, 01 Aug 2024 08:26:42 -0500 > > @Tommy do you think? You brought the issue up, I am assuming because you > found

Re: [VOTE] Release Apache Cassandra 4.1.6

ailto:%22j.%20d.%20jordan%22%20%3cjeremiah.jor...@gmail.com%3e>> Reply-To: dev@cassandra.apache.org<mailto:dev@cassandra.apache.org> To: dev@cassandra.apache.org<mailto:dev@cassandra.apache.org> Subject: Re: [VOTE] Release Apache Cassandra 4.1.6 Date: Thu, 01 Aug 2024 08:26:42 -0500 @Tom

Re: [VOTE] Release Apache Cassandra 4.1.6

@Tommy do you think?  You brought the issue up, I am assuming because you found the issue while trying to test ecaudit against the proposed release and it broke the integration? As an active consumer of the interface what are your thoughts?On Aug 1, 2024, at 8:17 AM, Alex Petrov wrote:> If we hav

Re: [VOTE] Release Apache Cassandra 4.1.6

> If we have a path that resolves the issue and also maintains full > compatibility for this (semi- / reluctantly-accessible) interface, that would > seem ideal. Interested to learn more about the drawbacks to that approach. My thinking here was that people who might have a binary dependency on

Re: [VOTE] Release Apache Cassandra 4.1.6

Sorry to veer off from a vote in a vote thread. @Alex, can you say more about this statement: > " I think I would prefer to not introduce the change I have proposed (the one that would bring back non-binary compatibility)." If we have a path that resolves the issue and also maintains full compati

Re: [VOTE] Release Apache Cassandra 4.1.6

+1 to proceeding with a simple upgrade note in NEWS On Wed, Jul 31, 2024 at 12:50 PM Josh McKenzie wrote: > Unfortunately, I can not immediately see a good way to provide the > critical bugfix of CASSANDRA-19534 > , affecting all > Cassandra

Re: [VOTE] Release Apache Cassandra 4.1.6

> Unfortunately, I can not immediately see a good way to provide the critical > bugfix of CASSANDRA-19534 > , affecting all > Cassandra users, without making at least some change in this API. > > I personally think that this method is very

Re: [VOTE] Release Apache Cassandra 4.1.6

I would make the case that loss of availability / significant performance issue, regardless of the amount of time it has existed for, is worth fixing on the branches that are widely deployed by the community. Especially when weighed against a loosely defined public interface issue. The queuing iss

Re: [VOTE] Release Apache Cassandra 4.1.6

Why does the age of the issue matter when it affects availability? On Tue, Jul 30, 2024 at 10:30 AM Jeff Jirsa wrote: > > It’s a 10 year old flaw in an 18 month old branch. Why does it need to go > into 4.1, it’s not a regression and it clearly breaks compatibility? > > > > > On Jul 30, 2024, at

Re: [VOTE] Release Apache Cassandra 4.1.6

It’s a 10 year old flaw in an 18 month old branch. Why does it need to go into 4.1, it’s not a regression and it clearly breaks compatibility? > On Jul 30, 2024, at 8:52 AM, Jon Haddad wrote: > > This patch fixes a long standing issue that's the root cause of availability > failures. Eve

Re: [VOTE] Release Apache Cassandra 4.1.6

I think I would prefer to not introduce the change I have proposed (the one that would bring back non-binary compatibility). I will wait a bit to see what other folks in the community think, but if we could just have a release note that anyone who happens to have their own custom query handler c

Re: [VOTE] Release Apache Cassandra 4.1.6

If there is a quick fix for the interface issue as Alex is describing then I am all for it. I think binary compatibility isn’t required here so the compile time compat would be good enough. Otherwise I tend to agree that while it should be considered a public interface we haven’t had a strict defi

Re: [VOTE] Release Apache Cassandra 4.1.6

I know of a few custom tracing implementations that implement a custom query handler to work.  No clue how maintained they still are.The elassandra project uses the custom query handler.DataStax uses the customer query handler for DSE (we maintain our own forks now, so can work around what ever hap

Re: [VOTE] Release Apache Cassandra 4.1.6

This patch fixes a long standing issue that's the root cause of availability failures. Even though folks can specify a custom query handler with the -D flag, the number of users impacted by this is going to be incredibly small. On the other hand, the fix helps every single user of 4.1 that puts t

Re: [VOTE] Release Apache Cassandra 4.1.6

Right, we do have "custom_query_handler_class". I was under impression it was used for testing, but checked the history, and it was around for a while, so it might have been used outside tests too. In this case we have 2 options: * to convert the new method in the interface to a "default" meth

Re: [VOTE] Release Apache Cassandra 4.1.6

Given we allow a pluggable query handler implementation to be specified for the server with a -D during startup. So I would consider the query handler one of our public interfaces.On Jul 30, 2024, at 9:35 AM, Alex Petrov wrote:Hi Tommy,Thank you for spotting this and bringing this to community's

Re: [VOTE] Release Apache Cassandra 4.1.6

Hi Tommy, Thank you for spotting this and bringing this to community's attention. I believe our primary interfaces are native and internode protocol, and CLI tools. Most interfaces are used to to abstract implementations internally. Few interfaces, such as DataType, Partitioner, and Triggers ca

Re: [VOTE] Release Apache Cassandra 4.1.6

Hi, There is a change in the QueryHandler interface introduced by https://issues.apache.org/jira/browse/CASSANDRA-19534 Do we allow changes such changes between 4.1.5 and 4.1.6? CASSANDRA-19534 looks like a very good change so maybe there is an exception in this case? /Tommy -Original Mes

Re: [VOTE] Release Apache Cassandra 4.1.6

Thanks Brandon! +1 Jon On Mon, Jul 29, 2024 at 7:37 AM Brandon Williams wrote: > Proposing the test build of Cassandra 4.1.6 for release. > > sha1: b662744af59f3a3dfbfeb7314e29fecb93abfd80 > Git: https://github.com/apache/cassandra/tree/4.1.6-tentative > Maven Artifacts: > > https://repository