Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-06-13 Thread Ekaterina Dimitrova
Thank you Maxim! I also agree with 1 and 2. Also, thank you for considering documentation. The datastax docs page mentioned here is not maintained by the project, the other one can get some love. I guess if we are adding description column, we can automate the way we populate that page. But I thin

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-06-13 Thread Mick Semb Wever
> I want also to clarify and discuss with you some points related to the > SystemPropertiesTable virtual table. > > 1. Hide non-production environment properties in the SystemProperties > virtual table. > > As you may know, the result of the query on the virtual table > currently includes the envir

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-06-13 Thread Maxim Muzafarov
perties. I do not think that it should take more > >> than 1 hour of dedicated effort and we are done! > >> > >> Thanks in advance to whoever reviews this. > >> > >> I want to especially thank Maxim for his perseverance in this matter and I > >> h

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-05-18 Thread Miklosovic, Stefan
n CQLSH as well. From: Maxim Muzafarov Sent: Thursday, May 18, 2023 12:54 To: dev@cassandra.apache.org Subject: Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties NetApp Security WARNING: This is an external email. Do not clic

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-05-18 Thread Maxim Muzafarov
pull/2046 >> (2) https://issues.apache.org/jira/browse/CASSANDRA-17797 >> >> Regards >> >> Regards >> >> ____________ >> From: Miklosovic, Stefan >> Sent: Wednesday, March 22, 2023 14:34 >> To: dev@cassandra.apache.org &g

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-03-30 Thread Jacek Lewandowski
> From: Miklosovic, Stefan > Sent: Wednesday, March 22, 2023 14:34 > To: dev@cassandra.apache.org > Subject: Re: [DISCUSS] Moving system property names to the > CassandraRelevantProperties > > NetApp Security WARNING: This is an external email. Do n

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-03-30 Thread Miklosovic, Stefan
://issues.apache.org/jira/browse/CASSANDRA-17797 Regards Regards From: Miklosovic, Stefan Sent: Wednesday, March 22, 2023 14:34 To: dev@cassandra.apache.org Subject: Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties NetApp Security

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-03-22 Thread Miklosovic, Stefan
is just about centralizing all properties scattered around the code base into one place. Regards From: Maxim Muzafarov Sent: Tuesday, March 21, 2023 22:59 To: dev@cassandra.apache.org Subject: Re: [DISCUSS] Moving system property names to the

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-03-21 Thread Maxim Muzafarov
Hello everyone, This a friendly reminder that some help is still needed with the review :-) I have resolved all the conflicts that have arisen in the last month or two. If you'd like to invest some time in code clarity, please take a look: https://github.com/apache/cassandra/pull/2046/files On W

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-02-09 Thread David Capwell
> Sure, a new checkstyle rule was added to address this case for production and > test classes. Glad to hear =) > On Feb 9, 2023, at 10:45 AM, Maxim Muzafarov wrote: > > David, > >> Should” we detect this was violated and fail the build? > > You are asking a good question! Sure, a new checks

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-02-09 Thread Maxim Muzafarov
David, > Should” we detect this was violated and fail the build? You are asking a good question! Sure, a new checkstyle rule was added to address this case for production and test classes. On Thu, 9 Feb 2023 at 19:40, David Capwell wrote: > > All properties meant to be used only for tests would

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-02-09 Thread David Capwell
> All properties meant to be used only for tests would have a prefix like > "cassandra.test.name.of.property" and production properties would be > "cassandra.xyx". Once this is done, we can filter them out in vtable so there > would not be any test-related properties in production. Test properti

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-02-09 Thread Miklosovic, Stefan
Hi Maxim, I would like to describe the ideal state / end goal, from my perspective. All properties meant to be used only for tests would have a prefix like "cassandra.test.name.of.property" and production properties would be "cassandra.xyx". Once this is done, we can filter them out in vtable s