Re: [DISCUSS] CEP-18: Improving Modularity

2021-11-03 Thread Jeremiah D Jordan
It seems like there are many people in this thread that would rather we not make a “grouping” CEP for these ideas, but rather consider each one individually. I will close out this CEP thread then, and discussions can continue on individual tickets. I think we got some nice discussion on this t

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-26 Thread Dinesh Joshi
> On Oct 25, 2021, at 1:22 PM, Jeremiah D Jordan wrote: > > The currently proposed changes in CEP-18 should all include improved test > coverage of the modules in question. We have been developing them all with a > requirement that all changes have at least %80 code coverage from sonar cloud

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-26 Thread bened...@apache.org
heavy pruning. From: Stefan Miklosovic Date: Tuesday, 26 October 2021 at 20:40 To: dev@cassandra.apache.org Subject: Re: [DISCUSS] CEP-18: Improving Modularity I am all for good extensibility / interfaces and so on, however I am afraid that this might actually break a lot of things if enough attent

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-26 Thread Jeremiah D Jordan
ers’ opinions about this. > > The only sub-proposal I’m particularly unsure about is 17059, which doesn’t > seem to increase modularity at all. It looks to be a kind of plugin hook, and > IMO should definitely be addressed separately. Perhaps a simple DISCUSS > thread and its Jira wil

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-26 Thread Stefan Miklosovic
those I have heard of, I am eager to see arrive in Cassandra. > > > > > > If the goal is to support entirely external features, we have to decide > > what kind of support we offer to these APIs, and this probably needs to be > > discussed on a per-API basis with the jus

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-26 Thread bened...@apache.org
assandra.apache.org Subject: Re: [DISCUSS] CEP-18: Improving Modularity > > To me having some defined interfaces for interacting with different > sections of the code is a huge boon for improving developer productivity > going forward in the project. Every place where we can reduce the a

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-26 Thread Joshua McKenzie
h I think is a primarily > to support an external dependency but we expect this area of the codebase > to be significantly revised over the coming months. > > > > > > From: Henrik Ingo henrik.i...@datastax.com>> > > Date: Monday, 25 October 2021 at 14:52 > &

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread Jeremiah D Jordan
Henrik Ingo mailto:henrik.i...@datastax.com>> > Date: Monday, 25 October 2021 at 14:52 > To: dev@cassandra.apache.org <mailto:dev@cassandra.apache.org> > mailto:dev@cassandra.apache.org>> > Subject: Re: [DISCUSS] CEP-18: Improving Modularity > Hi Benedict

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread David Capwell
ficantly revised over the coming months. > > > From: Henrik Ingo > Date: Monday, 25 October 2021 at 14:52 > To: dev@cassandra.apache.org > Subject: Re: [DISCUSS] CEP-18: Improving Modularity > Hi Benedict > > This CEP is a bundle of APIs arising out of our recent work

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread bened...@apache.org
schema, which I think is a primarily to support an external dependency but we expect this area of the codebase to be significantly revised over the coming months. From: Henrik Ingo Date: Monday, 25 October 2021 at 14:52 To: dev@cassandra.apache.org Subject: Re: [DISCUSS] CEP-18: Improving

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread David Capwell
I am cool with pluggability and making things easier to test; my main comment for this work is that we must also define semantics around the APIs and can't just create interfaces. Simple example of this is CASSANDRA-17058 (linked from the CEP

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread Henrik Ingo
Hi Benedict This CEP is a bundle of APIs arising out of our recent work to re-architect Cassandra into a more cloud native architecture. What our product marketing has chosen to call "Serverless" is a variant of Cassandra where we have separated compute from storage (coordinator vs data node), use

Re: [DISCUSS] CEP-18: Improving Modularity

2021-10-25 Thread bened...@apache.org
Hi Jeremiah, My personal view is that work to modularise the codebase should be tied to specific use cases. If improved testing is the purpose of this work, I think it would help to include those improved tests that you plan to support as goals for the CEP. If on the other hand some of this wo