Re: MerkleTree.RowHash maybe a bug.

2010-11-11 Thread Schubert Zhang
Hi Stu Hood, Yes, it may not result in extra repair, since the excess bytes of the Buffer may be same on different machine. e.g: all 0 bytes. But it depends on how the JDK (ByteArrayOutputStream) allocate memory, it is a risk for different JDK version. In fact, we have added compression feature i

RE: MerkleTree.RowHash maybe a bug.

2010-11-11 Thread Stu Hood
At first glance, this appeared to be a very egregious bug, but the effect is actually minimal: since the size of the buffer is deterministic based on the size of the data, you will have equal amounts of excess/junk data for equal rows. Combined with the fact that 0.6 doesn't reuse these buffers,