Re: Opinions about removal of deprecated code for upcoming 4.0

2020-04-16 Thread Stefan Miklosovic
That sounds all good to me. I ll check if there are some leftovers from 2.x as Jeff is describing. On Thu, 16 Apr 2020 at 10:24, Benjamin Lerer wrote: > > A lot of those methods if I am not wrong have been marked as deprecated in > 4.0. So they should not be removed yet, as Jeff mentioned. > > Th

Re: Opinions about removal of deprecated code for upcoming 4.0

2020-04-16 Thread Benjamin Lerer
A lot of those methods if I am not wrong have been marked as deprecated in 4.0. So they should not be removed yet, as Jeff mentioned. The problem I see is that those deprecations have not been mentioned in the deprecation section of the NEWS.txt. As they are MBeans methods, unless people have che

Re: Opinions about removal of deprecated code for upcoming 4.0

2020-04-15 Thread Jeff Jirsa
I havent reviewed that code, but it's not surprising there would be deprecated annotations in a major release. We *SHOULD* be deprecating things that worked in 3.0/3.11 in 4.0, and removing them in a future verison. We should only be removing them in 4.0 if they were originally supported in 2.1/2.2

Opinions about removal of deprecated code for upcoming 4.0

2020-04-15 Thread Stefan Miklosovic
Hi, I was going over StorageServiceMBean and I was quite surprised how many deprecated methods there are. Only in that interface itself there are 30 deprecation annotations. What is the general feeling about this as 4.0 is getting more real? One would say that 4.0 is "breaking change" release so I