Re: MerkleTree.RowHash maybe a bug.

2010-11-11 Thread Schubert Zhang
x27;ve opened CASSANDRA-1729 to fix it in > 0.6, in case we start reusing row buffers. > > Thanks for the report! > Stu > > -Original Message- > From: "Schubert Zhang" > Sent: Thursday, November 11, 2010 2:19am > To: dev@cassandra.apache.org, u...@cassan

RE: MerkleTree.RowHash maybe a bug.

2010-11-11 Thread Stu Hood
y, November 11, 2010 2:19am To: dev@cassandra.apache.org, u...@cassandra.apache.org Subject: MerkleTree.RowHash maybe a bug. Hi JE, 0.6.6: org.apache.cassandra.service.AntiEntropyService I found the rowHash method uses "row.buffer.getData()" directly. Since row.buffer.getData() is a byte[

MerkleTree.RowHash maybe a bug.

2010-11-11 Thread Schubert Zhang
Hi JE, 0.6.6: org.apache.cassandra.service.AntiEntropyService I found the rowHash method uses "row.buffer.getData()" directly. Since row.buffer.getData() is a byte[], and there may have some junk bytes in the end by the buffer, I think we should use the exact length. private MerkleTree.