Re: Keeping test-only changes out of CHANGES.txt

2020-04-15 Thread sankalp kohli
Thanks On Wed, Apr 15, 2020 at 10:32 AM Mick Semb Wever wrote: > > Can we vote(if required) on this as it looks largely everyone is in > > agreement? > > > I knew I forgot to post a reply here, thanks for the nudge sankalp, my bad. > > I took the above thread as consensus and last Friday committ

Re: Keeping test-only changes out of CHANGES.txt

2020-04-15 Thread Mick Semb Wever
> Can we vote(if required) on this as it looks largely everyone is in > agreement? I knew I forgot to post a reply here, thanks for the nudge sankalp, my bad. I took the above thread as consensus and last Friday committed it, along with the documentation update from Eduard. https://github.com/ap

Re: Keeping test-only changes out of CHANGES.txt

2020-04-15 Thread sankalp kohli
Can we vote(if required) on this as it looks largely everyone is in agreement? Also we can pile on documentation changes in the vote unless anyone objects. On Fri, Apr 10, 2020 at 2:52 PM Erick Ramirez wrote: > > > > In a conversation with Mick we discussed keeping doc changes out as well. > > A

Re: Keeping test-only changes out of CHANGES.txt

2020-04-10 Thread Erick Ramirez
> > In a conversation with Mick we discussed keeping doc changes out as well. > Anyone object to eliding documentation changes from CHANGES.txt? > +1 It will just get too noisy otherwise.

Re: Keeping test-only changes out of CHANGES.txt

2020-04-10 Thread Mick Semb Wever
> > > updated docs in https://github.com/apache/cassandra/pull/528 > > > Thanks Eduard and Jon. Committed in https://github.com/apache/cassandra/commit/141ea26733e7e8fe022bc78f7fd68225013e8d14 - To unsubscribe, e-mail: dev-uns

Re: Keeping test-only changes out of CHANGES.txt

2020-04-10 Thread e . dimitrova
+1 as soon as we always have JIRA number in the commit description Sent from my iPhone > On 10 Apr 2020, at 14:41, Brandon Williams wrote: > > +1 for keeping doc changes out. Definitely no good reason for keeping them. > >> On Fri, Apr 10, 2020 at 1:39 PM Jon Haddad wrote: >> >> In a conve

Re: Keeping test-only changes out of CHANGES.txt

2020-04-10 Thread Brandon Williams
+1 for keeping doc changes out. Definitely no good reason for keeping them. On Fri, Apr 10, 2020 at 1:39 PM Jon Haddad wrote: > > In a conversation with Mick we discussed keeping doc changes out as well. > Anyone object to eliding documentation changes from CHANGES.txt? > > > > > > > On Thu, Apr

Re: Keeping test-only changes out of CHANGES.txt

2020-04-10 Thread Jon Haddad
In a conversation with Mick we discussed keeping doc changes out as well. Anyone object to eliding documentation changes from CHANGES.txt? On Thu, Apr 9, 2020 at 1:07 AM Benjamin Lerer wrote: > +1 > > > > On Thu, Apr 9, 2020 at 9:28 AM Eduard Tudenhoefner < > eduard.tudenhoef...@datastax.co

Re: Keeping test-only changes out of CHANGES.txt

2020-04-09 Thread Benjamin Lerer
+1 On Thu, Apr 9, 2020 at 9:28 AM Eduard Tudenhoefner < eduard.tudenhoef...@datastax.com> wrote: > updated docs in https://github.com/apache/cassandra/pull/528 > > On Wed, Apr 8, 2020 at 11:39 PM Jordan West wrote: > > > +1 (nb) to the change and +1 (nb) to updating the docs to reflect this. >

Re: Keeping test-only changes out of CHANGES.txt

2020-04-09 Thread Eduard Tudenhoefner
updated docs in https://github.com/apache/cassandra/pull/528 On Wed, Apr 8, 2020 at 11:39 PM Jordan West wrote: > +1 (nb) to the change and +1 (nb) to updating the docs to reflect this. > > Jordan > > On Wed, Apr 8, 2020 at 11:30 AM wrote: > > > +1 > > > > > El 8 abr 2020, a las 19:05, e.dimitr

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Jordan West
+1 (nb) to the change and +1 (nb) to updating the docs to reflect this. Jordan On Wed, Apr 8, 2020 at 11:30 AM wrote: > +1 > > > El 8 abr 2020, a las 19:05, e.dimitr...@gmail.com escribió: > > > > +1 > > > > Sent from my iPhone > > > >> On 8 Apr 2020, at 13:50, Joshua McKenzie wrote: > >> > >

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread a . penya . garcia
+1 > El 8 abr 2020, a las 19:05, e.dimitr...@gmail.com escribió: > > +1 > > Sent from my iPhone > >> On 8 Apr 2020, at 13:50, Joshua McKenzie wrote: >> >> +1 >> On Wed, Apr 8, 2020 at 12:26 PM Sam Tunnicliffe wrote: >>> >>> +1 >>> > On 8 Apr 2020, at 15:08, Mick Semb Wever wro

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread e . dimitrova
+1 Sent from my iPhone > On 8 Apr 2020, at 13:50, Joshua McKenzie wrote: > > +1 > >> On Wed, Apr 8, 2020 at 12:26 PM Sam Tunnicliffe wrote: >> >> +1 >> On 8 Apr 2020, at 15:08, Mick Semb Wever wrote: >>> >>> Can we agree on keeping such test changes out of CHANGES.txt ? >>> >>> We

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Joshua McKenzie
+1 On Wed, Apr 8, 2020 at 12:26 PM Sam Tunnicliffe wrote: > +1 > > > On 8 Apr 2020, at 15:08, Mick Semb Wever wrote: > > > > Can we agree on keeping such test changes out of CHANGES.txt ? > > > > We already don't put entries into CHANGES.txt if it is not a change > > from any previous release.

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread David Capwell
+1 On Wed, Apr 8, 2020, 10:06 AM Dinesh Joshi wrote: > Could we please update the developer docs to reflect this? > > http://cassandra.apache.org/doc/latest/development/index.html > > Dinesh > > > On Apr 8, 2020, at 7:08 AM, Mick Semb Wever wrote: > > > > Can we agree on keeping such test chang

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Dinesh Joshi
Could we please update the developer docs to reflect this? http://cassandra.apache.org/doc/latest/development/index.html Dinesh > On Apr 8, 2020, at 7:08 AM, Mick Semb Wever wrote: > > Can we agree on keeping such test changes out of CHANGES.txt ? > > We already don't put entries into CHANGES

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Sam Tunnicliffe
+1 > On 8 Apr 2020, at 15:08, Mick Semb Wever wrote: > > Can we agree on keeping such test changes out of CHANGES.txt ? > > We already don't put entries into CHANGES.txt if it is not a change > from any previous release. > > There was some discussion before¹ about this, and the problem that >

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Yifan Cai
+1 From: Jasonstack Zhao Yang Sent: Wednesday, April 8, 2020 9:04:51 AM To: dev@cassandra.apache.org Subject: Re: Keeping test-only changes out of CHANGES.txt +1 On Thu, Apr 9, 2020, 00:04 Aleksey Yeshchenko wrote: > +1 > > > On 8 Apr 2020, at

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Jasonstack Zhao Yang
+1 On Thu, Apr 9, 2020, 00:04 Aleksey Yeshchenko wrote: > +1 > > > On 8 Apr 2020, at 15:08, Mick Semb Wever wrote: > > > > Can we agree on keeping such test changes out of CHANGES.txt ? > > > > We already don't put entries into CHANGES.txt if it is not a change > > from any previous release. >

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Aleksey Yeshchenko
+1 > On 8 Apr 2020, at 15:08, Mick Semb Wever wrote: > > Can we agree on keeping such test changes out of CHANGES.txt ? > > We already don't put entries into CHANGES.txt if it is not a change > from any previous release. > > There was some discussion before¹ about this, and the problem that >

Re: Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Benedict Elliott Smith
+1 On 08/04/2020, 16:53, "Mick Semb Wever" wrote: Can we agree on keeping such test changes out of CHANGES.txt ? We already don't put entries into CHANGES.txt if it is not a change from any previous release. There was some discussion before¹ about this, and the problem

Keeping test-only changes out of CHANGES.txt

2020-04-08 Thread Mick Semb Wever
Can we agree on keeping such test changes out of CHANGES.txt ? We already don't put entries into CHANGES.txt if it is not a change from any previous release. There was some discussion before¹ about this, and the problem that being selective meant what ended up there being arbitrary. I think this