Re: Immediately Deprecated Code

2023-11-01 Thread Mick Semb Wever
> My thought was that we have code that is intended to be used for a > specific time frame. > With your example of bloom filters, if that's on-disk then it is not to be removed. Specifically, code that is used in relation to a sstable format still listed in BigFormat.BigVersion (or BtiFormat.Bti

Re: Immediately Deprecated Code

2023-11-01 Thread Claude Warren, Jr via dev
made the move via 5.0 where you upgrade >>>> logic was triggered. >>>> >>>> (1) >>>> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L97-L108 >>>> >>>

Re: Immediately Deprecated Code

2023-10-31 Thread Mick Semb Wever
that a >>> problem? Because they have not made the move via 5.0 where you upgrade >>> logic was triggered. >>> >>> (1) >>> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L97-L1

Re: Immediately Deprecated Code

2023-10-31 Thread Claude Warren, Jr via dev
you upgrade >> logic was triggered. >> >> (1) >> https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L97-L108 >> >> ________ >> From: Claude Warren, Jr

Re: Immediately Deprecated Code

2023-10-31 Thread Andrew Weaver
.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L97-L108 > > > From: Claude Warren, Jr via dev > Sent: Tuesday, October 31, 2023 10:57 > To: dev > Cc: Claude Warren, Jr >

Re: Immediately Deprecated Code

2023-10-31 Thread Claude Warren, Jr via dev
sandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L97-L108 > > > From: Claude Warren, Jr via dev > Sent: Tuesday, October 31, 2023 10:57 > To: dev > Cc: Claude Warren, Jr > Subject: Immediatel

Re: Immediately Deprecated Code

2023-10-31 Thread Miklosovic, Stefan via dev
blob/trunk/test/distributed/org/apache/cassandra/distributed/upgrade/UpgradeTestBase.java#L97-L108 From: Claude Warren, Jr via dev Sent: Tuesday, October 31, 2023 10:57 To: dev Cc: Claude Warren, Jr Subject: Immediately Deprecated Code NetApp Security WAR

Immediately Deprecated Code

2023-10-31 Thread Claude Warren, Jr via dev
I was thinking about code that is used to migrate from one version to another. For example the code that rewrote the order of the hash values used for Bloom filters. That code was necessary for the version it was coded in. But the next version does not need that code because the next version is