Re: CONTRIBUTING.md

2025-08-25 Thread Ruslan Fomkin
> Thanks -- Joel. > > On 8/25/2025 2:02 AM, Ruslan Fomkin wrote: >> Hi Joel, >> >> Thank you for bringing the question of improving CONTRIBUTING.md. I’ve read >> the thread but not sure if there will be changes to the file. Thus, I will >> mention that the

Re: CONTRIBUTING.md

2025-08-25 Thread Joel Shepherd
rly for folks working in their own forked repo. Thanks -- Joel. On 8/25/2025 2:02 AM, Ruslan Fomkin wrote: Hi Joel, Thank you for bringing the question of improving CONTRIBUTING.md. I’ve read the thread but not sure if there will be changes to the file. Thus, I will mention that the following

Re: CONTRIBUTING.md

2025-08-25 Thread Ruslan Fomkin
Hi Joel, Thank you for bringing the question of improving CONTRIBUTING.md. I’ve read the thread but not sure if there will be changes to the file. Thus, I will mention that the following item caught my attention: > 3) Create your feature branch, named with the JIRA id (CASSANDRA-12345) >

Re: CONTRIBUTING.md

2025-08-20 Thread Nate McCall
Hi Joel, You are asking all the right questions here for updating this process and from a quick scan of the links on this thread, it's clear CONTRIBUTING.md needs some attention. I know from our conversations that this is not your first time at the rodeo, so feel free to bring this doc

Re: CONTRIBUTING.md

2025-08-19 Thread Joel Shepherd
Thanks Paulo - I'll add some notes on use of JIRA vs PR. Somewhat related ... The actual documentation on contributing in CONTRIBUTING.md is, well, light: two sentences total. Most of the information is actually in patches.adoc (https://github.com/apache/cassandra-website/blob/trunk

Re: CONTRIBUTING.md

2025-08-19 Thread Paulo Motta
I wanted to note that the main source of truth for design discussions should be JIRA - GH PR interface should be mostly used for code comments and not design discussions. This may not be clear for new contributors which are accustomed to the standard GH contribution workflow where design discussio

Re: CONTRIBUTING.md

2025-08-18 Thread Joel Shepherd
On 8/16/2025 2:39 AM, Mick wrote: The important thing to know (but maybe not mention), which is on the “how to commit” page, is that the GitHub PRs aren’t merged directly on GitHub, they’re committed manually on the upstream git repo branch by branch with an annotation to auto close them dow

Re: CONTRIBUTING.md

2025-08-16 Thread Mick
> The important thing to know (but maybe not mention), which is on the “how to > commit” page, is that the GitHub PRs aren’t merged directly on GitHub, > they’re committed manually on the upstream git repo branch by branch with an > annotation to auto close them downstream on GitHub And

Re: CONTRIBUTING.md

2025-08-15 Thread Jeff Jirsa
right and updating the docs is fine, as long as committers know how to actually commit. On Aug 15, 2025, at 4:20 PM, Joel Shepherd wrote: I think CONTRIBUTING.md needs a tweak, but I want to make sure I have the story straight before posting an edit. Currently, it

Re: CONTRIBUTING.md

2025-08-15 Thread Dinesh Joshi
Joel - your understanding of the process is correct. Almost nobody attaches patches to jiras these days. It would be great for you to update the doc. thanks, Dinesh On Fri, Aug 15, 2025 at 4:20 PM Joel Shepherd wrote: > I think CONTRIBUTING.md > <https://github.com/apache/cassa

CONTRIBUTING.md

2025-08-15 Thread Joel Shepherd
I think CONTRIBUTING.md <https://github.com/apache/cassandra/blob/b2037e473fb6438947d6ed9c58fbea5955cb72c4/CONTRIBUTING.md> needs a tweak, but I want to make sure I have the story straight before posting an edit. Currently, it states "Apache Cassandra doesn't use GitHub pull r