Re: CEP-15: Accord status

2024-09-30 Thread Patrick McFadin
I hear LLMs are good for this. Just something I saw on YouTube :D On Mon, Sep 30, 2024 at 5:40 AM Štefan Miklošovič wrote: > I think there was some discussion about putting that all to the website > which never materialized. > > On Mon, Sep 30, 2024 at 2:37 PM Josh McKenzie > wrote: > >> Today

Re: CEP-15: Accord status

2024-09-30 Thread Štefan Miklošovič
I think there was some discussion about putting that all to the website which never materialized. On Mon, Sep 30, 2024 at 2:37 PM Josh McKenzie wrote: > Today I learned… I had no clue we had markdown files in src/java… > > Discoverability issues in our codebase? > > Well I never. > > ;) > > On S

Re: CEP-15: Accord status

2024-09-30 Thread Josh McKenzie
> Today I learned… I had no clue we had markdown files in src/java… Discoverability issues in our codebase? Well I never. ;) On Sat, Sep 28, 2024, at 10:39 PM, David Capwell wrote: > Today I learned… I had no clue we had markdown files in src/java… > > $ find src/ -name '*.md' > src//java/org/a

Re: CEP-15: Accord status

2024-09-28 Thread David Capwell
Today I learned… I had no clue we had markdown files in src/java… $ find src/ -name '*.md' src//java/org/apache/cassandra/io/sstable/SSTable_API.md src//java/org/apache/cassandra/io/sstable/format/bti/BtiFormat.md src//java/org/apache/cassandra/utils/bytecomparable/ByteComparable.md src//java/org/

Re: CEP-15: Accord status

2024-09-27 Thread Paulo Motta
Thanks all for the work on this epic! Is there an implementation summary guide similar to guide_8099.md [1] that can help reviewers not involved with the effort navigate through the code ? It would be great to have it if this is not already available or being planned. There's a similar one though

Re: CEP-15: Accord status

2024-09-27 Thread Benedict Elliott Smith
If you exclude test changes, there’s < 50k added and ~2k removed. This works out to ~7% of the scale of 8099 for lines modified, if this is the benchmark for disruption. Altogether, this is a very small patch from the perspective of the existing codebase. Probably doesn’t even come close to the

Re: CEP-15: Accord status

2024-09-26 Thread David Capwell
Sorry for the late reply > How would you recommend interested parties engage with reviewing this > behemoth? I am not fully sure. Previous when we talked about merging to trunk there was pushback that people needed time to look at things, so I want to make sure we give people plenty of time.

Re: CEP-15: Accord status

2024-09-23 Thread Caleb Rackliffe
There is also a Jira to track pre-merge tasks here: https://issues.apache.org/jira/browse/CASSANDRA-18196 > On Sep 20, 2024, at 4:09 PM, Josh McKenzie wrote: > >  >> >> This presents an opportune moment for those interested to review the code. >> ... >> +88,341 −7,341 >> 1003 Files changed >

Re: CEP-15: Accord status

2024-09-20 Thread Josh McKenzie
> This presents an opportune moment for those interested to review the code. > ... > +88,341 −7,341 > 1003 Files changed O.o This is... **very large**. If we use CASSANDRA-8099 as our "banana for scale": > 645 files changed, 49381 insertions(+), 42227 deletions(-) To be clear - I don't think we

CEP-15: Accord status

2024-09-20 Thread David Capwell
Recently, we rebased against the trunk branch, ensuring that the accord branch is now in sync with the latest trunk version. This presents an opportune moment for those interested to review the code. We have a pending pull request (https://github.com/apache/cassandra/pull/3552) that we do not i