Re: [Discuss] Enabling JMX in in-jvm dtests (by default)

2023-08-25 Thread Miklosovic, Stefan
to execute nodetool commands. From: Doug Rohrer Sent: Friday, August 25, 2023 16:02 To: dev@cassandra.apache.org Subject: Re: [Discuss] Enabling JMX in in-jvm dtests (by default) You don't often get email from droh...@apple.com. Learn why th

Re: [Discuss] Enabling JMX in in-jvm dtests (by default)

2023-08-25 Thread Doug Rohrer
I’d agree that anywhere we’re calling `nodetoolResult` or `nodetool` in a test, it would be better to enable JMX and use it rather than the older mocks we set up to enable calling the mbeans directly. I don’t think enabling JMX by default is the right way to go mostly due to the added resources/

Re: [Discuss] Enabling JMX in in-jvm dtests (by default)

2023-08-25 Thread Brandon Williams
I would prefer to have one standard way to do it, and given the options I would prefer it be proper JMX instead of mocking. Kind Regards, Brandon On Fri, Aug 25, 2023 at 4:20 AM Miklosovic, Stefan wrote: > > Hi list, > > I want to gather a feedback for this comment (1). > > Long story short, unt

[Discuss] Enabling JMX in in-jvm dtests (by default)

2023-08-25 Thread Miklosovic, Stefan
Hi list, I want to gather a feedback for this comment (1). Long story short, until JMX feature was introduced, we kind of hacked / mocked the calls to MBeans from IInstance, like this (2). If you notice, there is a lot of methods throwing UnsupportedOperationException because we had no proper