Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-14 Thread David Capwell
> As such I would prefer to keep using the carrotsearch generators Works for me; I am cool with the added test dependency. > On Dec 14, 2022, at 7:13 AM, Mike Adamson wrote: > > I have had a look at whether we could use the QuickTheories in our randomized > testing and come to the following co

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-14 Thread Mike Adamson
I have had a look at whether we could use the QuickTheories in our randomized testing and come to the following conclusions: Pros: 1) It has a very rich set of random generators out of the box. 2) It has a very powerful mechanism for generating customised randomized datasets. 3) It is very pluggab

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-14 Thread Benedict
I don’t believe we are ready to be prescriptive about how our randomised tests are written.1) We want as many people to write randomised tests as possible, so do not want to create impediments.2) We don’t, I expect, all agree on what a good randomised test looks like.I think Mike should include car

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-14 Thread Mike Adamson
Thanks for your detailed response to this. I am definitely not fixed on using carrot for this so am happy to look at a replacement. I wasn't aware of the addition of QuickTheories or CassandraGenerators. A combination of these could easily supply the functionality we need for the SAI testing. The G

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-13 Thread Josh McKenzie
Whatever we decide on, let's make sure we document it so newcomers on the project (or really anyone new to property based testing) can better discover those things. https://cassandra.apache.org/_/development/testing.html On Tue, Dec 13, 2022, at 1:08 PM, David Capwell wrote: > Speaking to Caleb

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-13 Thread David Capwell
Speaking to Caleb in Slack, so putting the main comments I have there here… I am not -1 on this new dependency, but more asking what we should use for random testing moving forward…. ATM we have the following: 1) QuickTheories - I feel like I am the only user at this point… 2) 1-off - many reinv

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-13 Thread Caleb Rackliffe
We need random generators no matter what for these tests, so I think what we need to decide is whether to continue to use Carrot or migrate those to QuickTheories, along the lines of what we have now in org.apache.cassandra.utils.Generators. When it comes to a library like this, the thing I would

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-13 Thread Mike Adamson
> > Can you talk more about why? There are several ways to do random testing > in-tree ATM, so wondering why we need another one I can see one mechanism for random testing in-tree. That is the Simulator but that seems primarily involved in the random orchestration of operations. My apologies if

Re: [DISCUSSION] New dependencies for SAI CEP-7

2022-12-12 Thread David Capwell
> com.carrotsearch.randomizedtesting.randomizedtesting-runner 2.1.2 - test > dependency Can you talk more about why? There are several ways to do random testing in-tree ATM, so wondering why we need another one > On Dec 8, 2022, at 6:51 AM, Mike Adamson wrote: > > Hi, > > I wanted to discu

[DISCUSSION] New dependencies for SAI CEP-7

2022-12-08 Thread Mike Adamson
Hi, I wanted to discuss the addition of the following dependencies for CEP-7. The dependencies are: org.apache.lucene.lucene-core 7.5.0 org.apache.lucene.lucene-analyzers-common 7.5.0 com.carrotsearch.randomizedtesting.randomizedtesting-runner 2.1.2 - test dependency Lucene is an apache project