Since there was not major pushback, ill see this as green line for JIRA, ill
file later today
> On Nov 8, 2022, at 9:46 AM, David Capwell wrote:
>
> Thanks all for the replies, I hope I am posting a summary of all the feedback
>
> 1) double check with legal due to LGPL
> 2) need way to opt-out
Thanks all for the replies, I hope I am posting a summary of all the feedback
1) double check with legal due to LGPL
2) need way to opt-out during development similar to checkstyle
3) patch should be in the same spirit as the other build changes, hiding
details in .build and following naming
4) c
Fair point on the name both being more representative of what it does and
> being less scary. Wish we could think of something alpha-adjacent to "ant
> jar" so folks that are thinking "I want to build this thing" immediately
> see both options; the ant -p output is getting pretty long.
>
What's t
Miklosovic, Stefan wrote:
>>> I confused Jacoco to be code analysis tool instead of code coverage one.
>>> Early morning I guess :) I was thinking more about tooling like Sonar. What
>>> do you think about that? Any pros / cons to Spotbugs?
>>>
>>> _
you think about that? Any pros / cons to Spotbugs?
>
> ____________
> From: Miklosovic, Stefan
> Sent: Tuesday, November 8, 2022 11:36
> To: dev@cassandra.apache.org
> Subject: Re: [DISCUSSION] Add SpotBugs to the build
>
> Hi David, all
>
>
ons to Spotbugs?
>
>
> From: Miklosovic, Stefan
> Sent: Tuesday, November 8, 2022 11:36
> To: dev@cassandra.apache.org
> Subject: Re: [DISCUSSION] Add SpotBugs to the build
>
> Hi David, all
>
> what is the position of Jacoco i
, 2022 11:36
To: dev@cassandra.apache.org
Subject: Re: [DISCUSSION] Add SpotBugs to the build
Hi David, all
what is the position of Jacoco in Cassandra as this point? I see it in
build.xml there are some targets and infrastructure around that.
What is wrong with using Jacoco instead more heavily
From: David Capwell
Sent: Tuesday, November 8, 2022 0:10
To: dev
Subject: [DISCUSSION] Add SpotBugs to the build
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
I was
Positive David!
Can I suggest building on top of a change like this:
https://github.com/apache/cassandra/compare/cassandra-4.1...thelastpickle:cassandra:mck/buildfiles-linter-docs/4.1
i.e.
- moving all the linter stuff out to .build/build-linter.xml
- standardising on the -Dno-xxx approach (as we
+1 to static code analysis and hoping it's smart enough to check only
changed files instead of adding 30s to each build by checking everything
:fingerscrossed:
On 8/11/22 2:03, Brandon Williams wrote:
I suspect we'll have a -Dno-spotbugs flag as a counterpart to the
-Dno-checkstyle flag we hav
I suspect we'll have a -Dno-spotbugs flag as a counterpart to the
-Dno-checkstyle flag we have now.
Kind Regards,
Brandon
On Mon, Nov 7, 2022 at 6:45 PM Derek Chen-Becker wrote:
>
> I'm always in favor of having the compiler/runtime do more work for
> us, but I guess in the interest of gauging i
I would expect the role of SpotBugs to be advisory at first. After running it
on the code and evaluating the number and type of violations we can decide
which make sense to address and whether we would like it break the builds if it
detects violations.
>
> On Nov 7, 2022, at 4:45 PM, Derek Che
I'm always in favor of having the compiler/runtime do more work for
us, but I guess in the interest of gauging impact to dev productivity,
does this add much overhead? I guess we'll need to discuss what it
finds after it runs, as well.
Cheers,
Derek
On Mon, Nov 7, 2022 at 4:10 PM David Capwell
This is a good idea. Could you please run it by ASF legal just so we have all
our bases covered?
>
> On Nov 7, 2022, at 3:10 PM, David Capwell wrote:
>
> I was thinking that it would be good to add SpotBugs
> (https://spotbugs.github.io) into our build to help find bugs earlier in the
> lif
I was thinking that it would be good to add SpotBugs
(https://spotbugs.github.io) into our build to help find bugs earlier in the
life cycle. SpotBugs is LGPL but as it is used only in the build and not to
within this project, then this should be fine with Apache.
The motivation for adding thi
15 matches
Mail list logo
