Re: [DISCUSS] Jira state for second reviewer

2021-08-24 Thread Ekaterina Dimitrova
human being if they’re really > > > reviewing > > > > something or not, there’s no way to find out by yourself. If the > > > “Awaiting > > > > Second Review” state is interpreted as perhaps only needing a second > > > > reviewer, a report can ea

Re: [DISCUSS] Jira state for second reviewer

2021-08-12 Thread Brandon Williams
yourself. If the > > “Awaiting > > > Second Review” state is interpreted as perhaps only needing a second > > > reviewer, a report can easily distinguish this by listing the contents of > > > the Reviewers column. > > > > > > But, I don’t anticipa

Re: [DISCUSS] Jira state for second reviewer

2021-08-12 Thread Andrés de la Peña
by yourself. If the > “Awaiting > > Second Review” state is interpreted as perhaps only needing a second > > reviewer, a report can easily distinguish this by listing the contents of > > the Reviewers column. > > > > But, I don’t anticipate losing any sleep over whateve

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread Ekaterina Dimitrova
an easily distinguish this by listing the contents of > the Reviewers column. > > But, I don’t anticipate losing any sleep over whatever we decide here. > > From: Ekaterina Dimitrova > Date: Monday, 2 August 2021 at 15:37 > To: dev@cassandra.apache.org > Subject: Re: [DISC

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread bened...@apache.org
here. From: Ekaterina Dimitrova Date: Monday, 2 August 2021 at 15:37 To: dev@cassandra.apache.org Subject: Re: [DISCUSS] Jira state for second reviewer My only worry is that If we incorporate both things in one state this means that people won’t be able to find immediately tickets to assign for

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread Ekaterina Dimitrova
2 August 2021 at 15:15 > To: dev@cassandra.apache.org > Subject: Re: [DISCUSS] Jira state for second reviewer > Thank you all. > On Benedict’s question, my understanding is that the idea of Needs Second > Reviewer is to indicate we need to find a second reviewer. I suspect when >

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread bened...@apache.org
> > From: Brandon Williams > Date: Monday, 2 August 2021 at 14:57 > To: dev@cassandra.apache.org > Subject: Re: [DISCUSS] Jira state for second reviewer > +1 > > On Mon, Aug 2, 2021 at 8:40 AM Ekaterina Dimitrova > wrote: > > > > Hi everyone, > > >

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread Ekaterina Dimitrova
; From: Brandon Williams > Date: Monday, 2 August 2021 at 14:57 > To: dev@cassandra.apache.org > Subject: Re: [DISCUSS] Jira state for second reviewer > +1 > > On Mon, Aug 2, 2021 at 8:40 AM Ekaterina Dimitrova > wrote: > > > > Hi everyone, > > > > W

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread Paulo Motta
ew could not yet have gotten underway? > It’s unclear to me what you would do in this case – would it return to > Patch Available, or sit in Needs Second Reviewer? > > From: Brandon Williams > Date: Monday, 2 August 2021 at 14:57 > To: dev@cassandra.apache.org > Subject:

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread bened...@apache.org
Reviewer? From: Brandon Williams Date: Monday, 2 August 2021 at 14:57 To: dev@cassandra.apache.org Subject: Re: [DISCUSS] Jira state for second reviewer +1 On Mon, Aug 2, 2021 at 8:40 AM Ekaterina Dimitrova wrote: > > Hi everyone, > > While triaging tickets last week, we realized that t

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread Brandon Williams
+1 On Mon, Aug 2, 2021 at 8:40 AM Ekaterina Dimitrova wrote: > > Hi everyone, > > While triaging tickets last week, we realized that the new state works well > with only one caveat. The expectation is Patch Available to be used when > there is no reviewer available and Needs Reviewer to be used w

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread Paulo Motta
+1, agreed this makes its purpose more explicit. Em seg., 2 de ago. de 2021 às 10:40, Ekaterina Dimitrova < e.dimitr...@gmail.com> escreveu: > Hi everyone, > > While triaging tickets last week, we realized that the new state works well > with only one caveat. The expectation is Patch Available to

Re: [DISCUSS] Jira state for second reviewer

2021-08-02 Thread Ekaterina Dimitrova
Hi everyone, While triaging tickets last week, we realized that the new state works well with only one caveat. The expectation is Patch Available to be used when there is no reviewer available and Needs Reviewer to be used when we need a second reviewer. The name Needs Reviewer might be confusing

Re: [DISCUSS] Jira state for second reviewer

2021-07-08 Thread Benjamin Lerer
That sounds good to me. Thanks a lot Brandon and Ekaterina for taking care of that. Le mer. 7 juil. 2021 à 23:47, Ekaterina Dimitrova a écrit : > Hey everyone, > Considering the latest report of patches which need a reviewer, I think > this new Jira state is a great addition. > I took it one ste

Re: [DISCUSS] Jira state for second reviewer

2021-07-07 Thread Ekaterina Dimitrova
Hey everyone, Considering the latest report of patches which need a reviewer, I think this new Jira state is a great addition. I took it one step further today and asked for it to be available after PATCH AVAILABLE too. This is already implemented. I hope Brandon doesn’t mind my intervention. The r

Re: [DISCUSS] Jira state for second reviewer

2021-07-01 Thread Benjamin Lerer
+1 Le jeu. 1 juil. 2021 à 05:58, Caleb Rackliffe a écrit : > +1 > > > On Jun 30, 2021, at 4:38 PM, Brandon Williams wrote: > > > > Hello, > > > > Since our project governance requires two committers, which in some > > circumstances may mean two committers need to review, I'd like to add > > an

Re: [DISCUSS] Jira state for second reviewer

2021-06-30 Thread Caleb Rackliffe
+1 > On Jun 30, 2021, at 4:38 PM, Brandon Williams wrote: > > Hello, > > Since our project governance requires two committers, which in some > circumstances may mean two committers need to review, I'd like to add > another state to our jira such that finding tickets that need a second > review

Re: [DISCUSS] Jira state for second reviewer

2021-06-30 Thread Erick Ramirez
+1 sounds good. I recall seeing the conversation in #cassandra-dev -- weren't you also going to add a tag so it's easy to pick the tickets that need a second reviewer? Cheers!

[DISCUSS] Jira state for second reviewer

2021-06-30 Thread Brandon Williams
Hello, Since our project governance requires two committers, which in some circumstances may mean two committers need to review, I'd like to add another state to our jira such that finding tickets that need a second reviewer is possible, since it is not currently. On slack, Paulo Motta suggested