Re: [DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-07 Thread Mick Semb Wever
> Given zero copy streaming in the system … > For people using vnodes the current implementation of ZCS offers limited benefits. Until ZCS works for vnodes (sstables regardless of token range) I think we need to keep resumable. I doubt that the general 4.0 streaming improvements are enough – man

Re: [DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-03 Thread Bowen Song via dev
I should also add that because we use vnodes and STCS, in the absent of CASSANDRA-10540 , I don't think we will benefit from the zero copy streaming at all, as almost all SSTables files from the streaming source will contain a very wide tok

Re: [DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-03 Thread Bowen Song via dev
That was Cassandra 3.11, before the introduction of zero copy. But I must say I'm not certain whether the new zero copy streaming can prevent the long GC pauses, as I haven't tried it. On 03/08/2022 23:37, Josh McKenzie wrote: I had to resume the bootstrap once or twice in order to get these n

Re: [DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-03 Thread Josh McKenzie
> I had to resume the bootstrap once or twice in order to get these nodes > finish joinning the cluster. Was this before or after the addition of zero copy streaming? The premise is that the pain point resumable bootstrap targets is mitigated by the much faster bootstrapping times without the co

Re: [DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-03 Thread Bowen Song via dev
That would have to be assessed on a case by case basis. * When the code doesn't delete data, which means there's a zero probability of resurrecting deleted data, I will still use resumable bootstrap. * When resurrected data doesn't pose a problem to the system, it often can still be an accep

Re: [DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-03 Thread Jeff Jirsa
The hypothetical concern described is around potential data resurrection - would you still use resumable bootstrap if you knew that data deleted during those STW pauses was improperly resurrected? On Wed, Aug 3, 2022 at 2:40 PM Bowen Song via dev wrote: > I have benefited from the resumable boot

Re: [DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-03 Thread Bowen Song via dev
I have benefited from the resumable bootstrap before, and I'm in favour of keeping the feature around. I've had streaming failures due to long STW GC pauses on some bootstrapping nodes, and I had to resume the bootstrap once or twice in order to get these nodes finish joinning the cluster. The

[DISCUSS] Deprecate and remove resumable bootstrap and decommission

2022-08-03 Thread Josh McKenzie
Context: https://issues.apache.org/jira/browse/CASSANDRA-17679 >From the .yaml comment on the param I was working on adding: In certain environments, operators may want to disable resumable bootstrap in order to avoid potential correctness violations or data loss scenarios. Largely this centers