Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-06-02 Thread Maulin Vasavada
Thank you Dinesh and everybody. Will keep calm and wait for the feedback. Meanwhile I am experimenting with various implementation options for what I put as "will seek community's input

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-06-02 Thread Dinesh Joshi
Hi Maulin, Thank you for the CEP & Patch. I’ve been following along albeit silently. Will take a look. It’s just that we’re currently busy so bear with us. Thanks, Dinesh > On Jun 2, 2021, at 3:28 PM, Maulin Vasavada wrote: > > Hi all > > ^^^ bump ^^^ I've raised the PR and am waiting for

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-06-02 Thread Maulin Vasavada
Hi all ^^^ bump ^^^ I've raised the PR and am waiting for the review. Once I see that the suggested changes are directionally right I'll start a VOTE thread on the CEP (unless I am recommended to follow another process). Thanks Maulin On Thu, May 27, 2021 at 1:29 PM Maulin Vasavada wrote: > HI

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada
HI all I've raised the PR with the changes. Specifically I would appreciate the community's input on this section of the CEP

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada
Sounds good Brandon. I'll raise the PR in a couple of hours from now. Thanks. On Thu, May 27, 2021 at 10:14 AM Brandon Williams wrote: > You can raise a PR in any state, but review will be a different > matter. I would go ahead and raise it and the testing can be sorted > out from there. > > On

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Brandon Williams
You can raise a PR in any state, but review will be a different matter. I would go ahead and raise it and the testing can be sorted out from there. On Thu, May 27, 2021 at 12:12 PM Maulin Vasavada wrote: > > Hi all > > I think I am close to raising a PR now but my CircleCI job >

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-27 Thread Maulin Vasavada
Hi all I think I am close to raising a PR now but my CircleCI job doesn't make progress beyond key tasks success like unit tests, dtests, cqlshlibtests. Any recommendation on if we need to see the whole CircleCI job green before

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-21 Thread Maulin Vasavada
I am almost done with all changes except the code snippet in the EncryptioOptions.java which determines 'enabled' and 'optional' encryption flags. Will raise the PR soon once I see my CircleCI getting green. On Fri, May 21, 2021 at 9:24 AM Maulin Vasavada wrote: > FYI - I am working on PR. I mad

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-21 Thread Maulin Vasavada
FYI - I am working on PR. I made some changes and trying to run tests. On Tue, May 18, 2021 at 10:14 PM Maulin Vasavada wrote: > Thanks Nate for reviewing the CEP. Yes for change #3 in the CEP, I mean to > have only single Default Impl and that would be a final class, not > overridable. It will

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-18 Thread Maulin Vasavada
Thanks Nate for reviewing the CEP. Yes for change #3 in the CEP, I mean to have only single Default Impl and that would be a final class, not overridable. It will be basically an internal implementation. I've updated the CEP to reflect this. On Tue, May 18, 2021 at 7:21 PM Nate McCall wrote: > H

Re: [DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-18 Thread Nate McCall
Hi Maulin, Thanks for putting this together! Took a quick glance, and I can't think of a compelling reason on why SSLContext should be final and your point about organization/compliance issues requiring different implementations is a good one. Per #3 on your proposed changes, I'm keen to only sup

[DISCUSS] CIP-9: Make SSLContext creation pluggable

2021-05-18 Thread Maulin Vasavada
Hi all Starting a discussion thread for the CIP-9 - https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-9%3A+Make+SSLContext+creation+pluggable However, while writing the CIP two areas that came up in my mind where I need to seek guidance apart from the other discussion that we would have