> Providing some guidance seems like a reasonable step to take. Would that be
> in our coding guidelines
To my knowledge we don't currently codify guidance on idiomatic usage of
various things in the project, but if we did, that'd probably be the place to
put them.
Also, fwiw, I think we should
I am in favor of adding the dependency but like many others have already said,
it would be nice to outline what and why are we using it?
Dinesh
> On Oct 1, 2022, at 9:57 AM, Derek Chen-Becker wrote:
>
> Providing some guidance seems like a reasonable step to take. Would that be
> in our codin
Providing some guidance seems like a reasonable step to take. Would that be
in our coding guidelines (
https://cassandra.apache.org/_/development/code_style.html) or do we have
other places where we provide development guidelines? I like your
optimism on Valhalla's timeline, but I also agree that t
I agree we need to be cautious about permitting overlapping functionality. I
think if there are other utilities that duplicate existing functionality we
should have a similar discussion on list before we begin using it, even after
including the library. Perhaps even our wording around seeking in
We can also enforce this with checkstyle, whatever we decide.
Kind Regards,
Brandon
On Thu, Sep 29, 2022 at 9:25 AM Derek Chen-Becker wrote:
>
> +1 from me with some concerns.
>
> Agrona looks like a nice lib, and I like what I've seen skimming the docs,
> but I think there's a longer-term disc
+1 from me with some concerns.
Agrona looks like a nice lib, and I like what I've seen skimming the docs,
but I think there's a longer-term discussion around whether we want to do
anything about bringing in a library that effectively duplicates a bunch of
standard lib constructs. My main concern i
Also +1
> On 23 Sep 2022, at 18:17, David Capwell wrote:
>
> +1 from me
>
>> On Sep 23, 2022, at 1:21 AM, Branimir Lambov
>> wrote:
>>
>> The usage in the trie memtable is only for volatile access to buffers. In
>> this case I chose the library instead of reimplementing the functionality
+1 from me
> On Sep 23, 2022, at 1:21 AM, Branimir Lambov
> wrote:
>
> The usage in the trie memtable is only for volatile access to buffers. In
> this case I chose the library instead of reimplementing the functionality
> (e.g. as methods in `ByteBufferUtil`) because the relevant interface m
The usage in the trie memtable is only for volatile access to buffers. In
this case I chose the library instead of reimplementing the functionality
(e.g. as methods in `ByteBufferUtil`) because the relevant interface makes
sense and the library is a good quality one that contains a range of other
u
Agrona looks like it has quite a bit more than just buffers, so if we add
this as a dependency for the new memtable, would it potentially open up use
of other parts of Agrona (wittingly or not)? Unless I misunderstood, wasn't
part of the new memtable implementation an interface to allow this to be
+1 to David and Benedict's sentiments here. Probably a good habit for us to get
into in general (including the "why" when hitting up ML about a new dep)
On Wed, Sep 21, 2022, at 1:29 PM, David Capwell wrote:
> I am +1 to adding, good library, but agree with Benedict it would be good to
> know “w
I am +1 to adding, good library, but agree with Benedict it would be good to
know “why”.
> On Sep 21, 2022, at 5:40 AM, Benedict wrote:
>
> In principle no, it’s a high quality library. But it might help to briefly
> outline what it’s used for. I assume it is instead of ByteBuffer? In which
>
In principle no, it’s a high quality library. But it might help to briefly
outline what it’s used for. I assume it is instead of ByteBuffer? In which case
it could maybe be worthwhile discussing as a project how we foresee interaction
with existing buffer machinery, and maybe how we expect our b
+1
On Wed, Sep 21, 2022, 7:28 AM Branimir Lambov wrote:
> Hi everyone,
>
> CASSANDRA-17240 (Trie memtable implementation) introduces a dependency on
> the agrona library (https://github.com/real-logic/agrona).
>
> Does anyone have any objections to adding this dependency?
>
> Regards,
> Branimi
Almost added it twice myself. High quality library with many nifty classes, +1
from me.
> On 21 Sep 2022, at 13:28, Branimir Lambov wrote:
>
> Hi everyone,
>
> CASSANDRA-17240 (Trie memtable implementation) introduces a dependency on the
> agrona library (https://github.com/real-logic/agrona
Hi everyone,
CASSANDRA-17240 (Trie memtable implementation) introduces a dependency on
the agrona library (https://github.com/real-logic/agrona).
Does anyone have any objections to adding this dependency?
Regards,
Branimir
16 matches
Mail list logo
