Re: [Discuss] Repair inside C*

2024-10-28 Thread Jaydeep Chovatia
> > > > That's inaccurate, we can check the replica set for the subrange we're about to run and see if it overlaps with the replica set of other ranges which are being processed already. We can definitely check the replicas for the subrange we plan to run and see if they overlap with the ongoing on

Re: [Discuss] Repair inside C*

2024-10-28 Thread Jeff Jirsa
> On Oct 28, 2024, at 9:52 PM, Alexander Dejanovski > wrote: > >  > >> If a repair session finishes gracefully, then this timeout is not >> applicable. Anyway, I do not have any strong opinion on the value. I am open >> to lowering it to 1h or something. > True, it will only delay killing

Re: [Discuss] Repair inside C*

2024-10-28 Thread Alexander Dejanovski
> > The scheduler repairs, by default, the primary ranges for all the nodes > going through the repair. Since it uses the primary ranges, all the nodes > repairing parallelly would not overlap in any form for the primary ranges. > However, the replica set for the nodes going through repair may or m

Re: [Discuss] Repair inside C*

2024-10-28 Thread Jaydeep Chovatia
Thanks, Mick, for the comment, please find my response below. >(1) I think I covered most of the points in my response to Alexander (except one, which I am responding to below separately). Tl;dr is the MVP that can be easily extended to do a table-level schedule; it is just going to be another CQ

Re: [Discuss] Repair inside C*

2024-10-28 Thread Jaydeep Chovatia
Thanks a lot, Alexander, for the review! Please find my response below: > making these replicas process 3 concurrent repairs while others could be left uninvolved in any repair at all...Taking a range centric approach (we're not repairing nodes, we're repairing the token ranges) allows to spread

Re: [Discuss] Repair inside C*

2024-10-28 Thread Mick Semb Wever
any name works for me, Jaydeep :-) I've taken a run through of the CEP, design doc, and current PR. Below are my four (rough categories of) questions. I am keen to see a MVP land, so I'm more looking at what the CEP's design might not be able to do, rather than what may or may not land in an init

Re: [Discuss] Repair inside C*

2024-10-28 Thread Alexander DEJANOVSKI
Hi Jaydeep, I've taken a look at the proposed design and have a few comments/questions. As one of the maintainers of Reaper, I'm looking this through the lens of how Reaper does things. *The approach taken in the CEP-37 design is "node-centric" vs a "range centric" approach (which is the one Rea

Re: [DISCUSS] Introduce CREATE TABLE LIKE grammer

2024-10-28 Thread guo Maxwell
Here is the latest updated CEP-43 guo Maxwell 于2024年10月24日周四 19:53写道: > yes,you are right. I will add this > > Štefan Miklošovič 于2024年10月24日 周四下午4:42写道: > >> The CEP should also mention that co