easy-cass-lab supports 5.0 RC1

2024-07-23 Thread Jon Haddad
Hey everyone! If you've already seen the news that 5.0 RC-1 is out, you might be wondering how you can kick the tires without investing a ton of time into changing your tooling around. I've got you covered :) I've just released an update to easy-cass-lab [1], my tooling to spin up Cassandra envi

Let's get ready for Cassandra 5!

2024-07-23 Thread Patrick McFadin
Hi everyone, If you haven't seen, we are now at 5.0-rc1 which means we are close to GA. Anticipating that movement, I'm going to be getting our official release blog ready and wanted to ask for some help. If you have been testing/using/breaking 5.0 and would like to offer a quote, it adds a lot to

Re: [DISCUSS] The way we log

2024-07-23 Thread Mick Semb Wever
On Tue, 23 Jul 2024 at 15:27, J. D. Jordan wrote: > I don’t know that I agree we should remove use if isDebugEnabled, but we > should be assuming debug is enabled and not doing anything too crazy there. > The problem is that the use of isDebugEnabled, as trivial as it is, leads to the typical a

Re: [DISCUSS] The way we log

2024-07-23 Thread Štefan Miklošovič
> > I do not agree we should remove isDebugEnabled tests, as debug logging > should be possible to turn off and avoid any penalty. > if (logger.isDebugEnabled()) logger.debug("hello") is performance-wise same as doing logger.debug("hello") we already went through this, the latter version in

Re: [DISCUSS] The way we log

2024-07-23 Thread Benedict Elliott Smith
1) That is not the current state of the code; 2) We should anyway not be codifying something just because a handful of people have been doing it. C-10241 does not accord with this view either - it makes clear the debug log output should be for "where we can log things that might help if somethin

Re: [DISCUSS] The way we log

2024-07-23 Thread Štefan Miklošovič
I don't know what consists of "too crazy" in your books. It would look same as it is now after we removed isTracingEnabled. Maybe going through the opening email and seeing the reasoning why, similarly, isDebugEnabled is not always necessary would be helpful? On Tue, Jul 23, 2024 at 3:27 PM J. D.

Re: [DISCUSS] The way we log

2024-07-23 Thread J. D. Jordan
I don’t know that I agree we should remove use if isDebugEnabled, but we should be assuming debug is enabled and not doing anything too crazy there.The description of the log levels from the old wiki describes the state of our logging very well, +1 to get that back into the docs.If someone wants to

Re: [DISCUSS] The way we log

2024-07-23 Thread Štefan Miklošovič
For the record, I am OK with removing logger.isDebugEnabled() in the same spirit as it was done with logger.isTracingEnabled(). That is, some invocations of isDebugEnabled() are not necessary, logger.debug() is just enough, I already went through the reasons why it is so in the first email from whi

Re: [DISCUSS] The way we log

2024-07-23 Thread Mick Semb Wever
> I disagree with all of this. Debug logging *can* be enabled for > production clusters, but it should not be on by default. > > DEBUG should *not* be taken to mean “background activities” and we should > stamp this out wherever this has been occurring. DEBUG means verbose > logging for use debuggi

Re: [DISCUSS] The way we log

2024-07-23 Thread Benedict Elliott Smith
I disagree with all of this. Debug logging can be enabled for production clusters, but it should not be on by default. DEBUG should not be taken to mean “background activities” and we should stamp this out wherever this has been occurring. DEBUG means verbose logging for use debugging system be

Re: [DISCUSS] The way we log

2024-07-23 Thread Mick Semb Wever
reply below… On Thu, 30 May 2024 at 14:34, Štefan Miklošovič wrote: > I see the feedback is overall positive. I will merge that and I will > improve the documentation on the website along with what Benedict suggested. > I think the codestyle needs to be more explicit that this applies _only_