Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Ariel Weisberg
This particular library doesn't really present transitive dependency issues. We already manually specify the version of the two dependencies that look like the runtime dependencies. On Tue, Jul 16, 2024, at 11:39 AM, Jeff Jirsa wrote: > (Answering this as a cassandra person, don’t confuse this

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread David Capwell
I am not for or against replacing… > I'm talkingabout CEP-38 [1], where I want to reuse the NodeTool commands and > execute them via CQL > 1. So the first requirement that airline doesn't fulfil is to allow us > to stay aside from all API-specific options of the commands and only > use them whe

[DISCUSS] Request for feedback re: new large features to (potentially) be added to the Apache Cassandra drivers still maintained by DataStax

2024-07-16 Thread Bret McGuire
Greetings all! As we get closer and closer to the release of Apache Cassandra 5.0 the drivers team at DataStax would like to solicit feedback from the Cassandra community about what major features users would like to see across the various actively maintained drivers. We’re considering focusin

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Caleb Rackliffe
With concerns around licensing all but resolved, I'd support Pico as our airline replacement. It looks like it would entail the least risky migration, is being actively maintained, will make the development of a number of planned enhancements easier, etc. On Tue, Jul 16, 2024 at 10:40 AM Jeff Jirs

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Jeff Jirsa
(Answering this as a cassandra person, don’t confuse this reply as board/foundation guidance) The legal landscape is rapidly evolving with the CRA. The answer may change in the future, but I think “we have a dependency we ship that’s user-accessible and known to be abandoned” is an unhappy stat

Re: [CASSANDRA-19651][Review] idealCLWriteLatency metric reports the worst response time instead of the time when ideal CL is satisfied

2024-07-16 Thread Ariel Weisberg
Hi, I'll take a look. Thanks! Ariel On Wed, Jul 10, 2024, at 7:18 AM, Dmitry Konstantinov wrote: > Hello All, > > I recently submitted a patch what addresses a bug in idealCLWriteLatency > metric calculation: https://issues.apache.org/jira/browse/CASSANDRA-19651 > > Could someone help with re

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Ariel Weisberg
Hi, I am pretty torn down the middle on this one. Unmaintained bad, but also Aleksey is right. If there are few/no dependencies in airline then it could be "done" given the narrow scope of what it does. It seems to depend on Guava, javax.inject, and findbugs. Seems like we can probably update

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Maxim Muzafarov
Aleksey, I wouldn't think of the NodeTool commands and the airline library it now uses as just the cli commands (other tools are less interesting), in a broader sense these are commands to manage a node. I'm talking about CEP-38 [1], where I want to reuse the NodeTool commands and execute them via

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Štefan Miklošovič
Well, we might probably stick to that, sure. If nobody objects that there is a big fat warning about airline being deprecated and it actually actively promotes picocli or airline 2 as its replacement in its readme. https://github.com/airlift/airline I get that the motivation to not change it (pro

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Aleksey Yeshchenko
Are there outstanding bugs in airline though, and any that affect Cassandra specifically? There is software that requires ongoing maintenance and these is software that really doesn’t. These are simple libraries, doing one isolated thing, that don’t need to change once they work - they are *don

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Štefan Miklošovič
I do not think it is completely fair to say that it is maintained by a single individual. Looking into the commit history, the author of Picocli is accepting patches from other contributors as well. Also, I think this library is so broadly used that it is not going anywhere even if the original aut

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Claude Warren, Jr via dev
There are several reasons to consider updating, foremost in my mind is the changes coming as part of CRA in Europe. IANAL, but I don't think that non-maintained code will meet the CRA requirements, nor will code maintained by a single individual. Our best approach may be to try to get picocli me

Re: [DISCUSS] Replace airlift/airline library with Picocli

2024-07-16 Thread Aleksey Yeshchenko
Hi Maxim, I think I’m not fully sold on the need to do anything at all here. The library may no longer be maintained, but so what if it isn’t, really? Parsing command line arguments is a pretty well defined problem, it’s not the kind of code that rots and needs to be updated to stay operational