Re: Future direction for the row cache and OHC implementation

2023-12-15 Thread Josh McKenzie
Gotcha; wasn't sure given the earlier phrasing. Makes sense. Dinesh's compromise position makes sense to me. On Fri, Dec 15, 2023, at 11:21 PM, Ariel Weisberg wrote: > Hi, > > I did get one response from Robert indicating that he didn’t want to do the > work to contribute it. > > I offered to

Re: Future direction for the row cache and OHC implementation

2023-12-15 Thread Ariel Weisberg
Hi, I did get one response from Robert indicating that he didn’t want to do the work to contribute it. I offered to do the work and asked for permission to contribute it and no response. Followed up later with a ping and also no response. Ariel On Fri, Dec 15, 2023, at 9:58 PM, Josh McKenzie

Re: Moving Semver4j from test to main dependencies

2023-12-15 Thread Mick Semb Wever
I'd like to add Semver4j to the production dependencies. It is currently on > the test classpath. The library is pretty lightweight, licensed with MIT > and has no transitive dependencies. > > We need to represent the kernel version somehow in CASSANDRA-19196 and > Semver4j looks as the right tool

Re: Moving Semver4j from test to main dependencies

2023-12-15 Thread Josh McKenzie
+1 On Fri, Dec 15, 2023, at 1:29 PM, Derek Chen-Becker wrote: > +1 > > Semver4j seems reasonable to me. I looked through the code and it's > relatively easy to understand. I'm not sure how easy it would be to replace > CassandraVersion, but that's not an immediate concern I guess. > > Cheers,

Re: Future direction for the row cache and OHC implementation

2023-12-15 Thread Josh McKenzie
> I have reached out to the original maintainer about it and it seems like if > we want to keep using it we will need to start releasing it under a new > package from a different repo. > the current maintainer is not interested in donating it to the ASF Is that the case Ariel or could you just n

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-12-15 Thread Josh McKenzie
> First of all - when you want to have a parameterized test case you do not > have to make the whole test class parameterized - it is per test case. Also, > each method can have different parameters. This is a pretty compelling improvement to me having just had to use the somewhat painful and bl

Re: Custom FSError and CommitLog Error Handling

2023-12-15 Thread Josh McKenzie
Adding a poison-pill error option on finding of corrupt data makes sense to me. Not sure if there's enough demand / other customization being done in this space to justify the user customizable aspect; any immediate other approaches come to mind? If not, this isn't an area of the code that's cha

Re: [DISCUSS] CEP-39: Cost Based Optimizer

2023-12-15 Thread Josh McKenzie
> Goals > • Introduce a Cascades(2) query optimizer with rules easily extendable > • Improve query performance for most common queries > • Add support for EXPLAIN and EXPLAIN ANALYZE to help with query > optimization and troubleshooting > • Lay the groundwork for the addition of features like

Re: [DISCUSS] CEP-36: A Configurable ChannelProxy to alias external storage locations

2023-12-15 Thread Jon Haddad
At a high level I really like the idea of being able to better leverage cheaper storage especially object stores like S3. One important thing though - I feel pretty strongly that there's a big, deal breaking downside. Backups, disk failure policies, snapshots and possibly repairs would get more

Re: Moving Semver4j from test to main dependencies

2023-12-15 Thread Derek Chen-Becker
+1 Semver4j seems reasonable to me. I looked through the code and it's relatively easy to understand. I'm not sure how easy it would be to replace CassandraVersion, but that's not an immediate concern I guess. Cheers, Derek On Fri, Dec 15, 2023 at 2:56 AM Jacek Lewandowski < lewandowski.ja...@g

Re: Future direction for the row cache and OHC implementation

2023-12-15 Thread Jeremiah Jordan
> > from a maintenance and > integration testing perspective I think it would be better to keep the > ohc in-tree, so we will be aware of any issues immediately after the > full CI run. >From the original email bringing OHC in tree is not an option because the current maintainer is not interested

Re: [DISCUSS] CEP-39: Cost Based Optimizer

2023-12-15 Thread Chris Lohfink
Thanks for time in addressing concerns. At least with initial versions, as long as there is a way to replace it with noop or disable it I would be happy. This is pretty standard practice with features nowadays but I wanted to highlight it as this might require some pretty tight coupling. Chris On

Re: [DISCUSS] CEP-39: Cost Based Optimizer

2023-12-15 Thread Benjamin Lerer
> > I'm also torn on the CEP as presented. I think some of it is my negative > emotional response to the examples - e.g. I've literally never seen a real > use case where unfolding constants matters, and I'm trying to convince > myself to read past that. I totally agree with you, Jeff, if you thi

Re: [DISCUSS] CEP-39: Cost Based Optimizer

2023-12-15 Thread Benjamin Lerer
Hey Chris, You raise some valid points. I believe that there are 3 points that you mentioned: 1) CQL restrictions are some form of safety net and should be kept 2) A lot of Cassandra features do not scale and/or are too easy to use in a wrong way that can make the whole system collapse. We should

Re: Future direction for the row cache and OHC implementation

2023-12-15 Thread Maxim Muzafarov
Ariel, thank you for bringing this topic to the ML. I may be missing something, so correct me if I'm wrong somewhere in the management of the Cassandra ecosystem. As I see it, the problem right now is that if we fork the ohc and put it under its own root, the use of that row cache is still not we

Moving Semver4j from test to main dependencies

2023-12-15 Thread Jacek Lewandowski
Hi, I'd like to add Semver4j to the production dependencies. It is currently on the test classpath. The library is pretty lightweight, licensed with MIT and has no transitive dependencies. We need to represent the kernel version somehow in CASSANDRA-19196 and Semver4j looks as the right tool for