Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-06-01 Thread David Capwell
Hmmm, did you try without —remote? We 100% rely on git hooks, and this is what we do $ grep -r 'git submodule' .build/ .build//sh/bump-accord.sh: git submodule status modules/accord .build//sh/change-submodule.sh: git submodule set-url "${path}" "${url}" .build//sh/change-submodule.sh: git s

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-06-01 Thread Josh McKenzie
> Josh, do you see any reports on what isn’t working? I think most people > don’t touch 1% of what git can do… so it might be that 10% is broken but that > no one in our domain actually touches that path? Was changing .gitmodule in harry to point to a branch and git just straight up went out to

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-06-01 Thread David Capwell
To be clear, we only use the relative syntax during development and not long lived feature branches like cep-15-accord; we use https address there. So when you create a PR you switch to relative paths (if-and-only-if you change the submodule), then on merge you switch back to https pointing to

Re: [DISCUSS] Bring cassandra-harry in tree as a submodule

2023-06-01 Thread David Capwell
Most edge cases we have seen in Accord are working with feature branches from other authors where we use relative paths to make sure the git@ vs https:// doesn’t become a problem for CI (submodule points to https:// to work in CI, but if you do that during feature development it gets annoying to