Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread scott
For me, the strongest arguments in favor of adopting a modern build tool like Maven or Gradle are their ecosystems - both explicit (in terms of plugins), and implicit (in terms of nearly all build tooling supporting both of them, but not ant). Investment in Ant - and in tooling that integrates

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Benedict
I think modules are already fairly well supported - we in effect already have several? FQL, Simulator and others I think. I can anyway say with absolute certainty that the main impediment to modularising is not build tooling, it’s the difficulty of the task, the cost to the project of undertaki

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Miklosovic, Stefan
I agree with what you wrote. How I understand it is that migrating to Maven/Gradle makes the project more "attractive" for newcomers. If a project is built on "that old un-cool Ant", it might be a little bit off-putting and questionable if we are "stuck in the past on build systems and not progr

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Benedict
I should say, if a majority of the core developers are secretly really keen to see one of the other build systems takeover, I won’t stand in the way. But my preference is not to take the productivity hit, and I know many of the core developers prefer to avoid active involvement on list, and I su

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Benedict
There’s always a handful of people asking for it, but notably few if any of the full time contributors doing the majority of the core development of Cassandra. It strikes me as something very appealing to others, but less so to those wanting to get on with development. I never really see a good

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Miklosovic, Stefan
Interesting take on Ant / no-Ant, Benedict. I am very curious how this unfolds. My long-term perception is that changing it to something else is more or less inevitable but if there is a broader consensus to not do that well. From: Benedict Sent: Fr

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Benedict
I was in a bit of a rush last night. I should say that I’m of course +1 a general endeavour to clean this up, and to expand our use of linters, and I appreciate your volunteering to help out in this way Maxim. However, responding to Stefan, I’m pretty -1 migrating from ant to another build sys

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Miklosovic, Stefan
For the record, I was testing that same combo Claude mentioned and it did not work out of the box but it is definitely possible to set up successfully. I do not remember the details. To replay to Maxim, it all seems good to me, roughly, but I humbly think it all boils down to Maven/Gradle refac

Re: [DISCUSSION] Cassandra's code style and source code analysis

2022-11-25 Thread Claude Warren, Jr via dev
+1 for the concept as a whole. I am certain I could find nits to pick if I looked deeply. @mck -- I did have a problem with Cassandra + Eclipse + Java11 (Classpath). I gave up and am spending time trying to learn IntelliJ. I also mentioned it in one of the discussion areas. Claude On Thu, Nov