Re: Some tests are never executed in CI due to their name

Aha wait a minute I got it :D Yeah. This is not what you invented, it is already in, sorry. So, you are saying we should just modify this to cover @Test / abstract. I dont know ... interesting. Lets wait for others to answer. From: Josh McKenzie Sent:

Re: Some tests are never executed in CI due to their name

Finish it all to the completion be if you don't mind. To see it all in action. Again, I don't know what to do with this function, sorry. Why is it in builds? So standalone build.xml and ant target would be without this or we would need to duplicate? I am by no mean against this exploration, I w

Re: Some tests are never executed in CI due to their name

> I just feel we need to plumb this on quite a low level to achieve this. Why > not to put a 5 line checkstyle in place, rename few classes and move on. https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-test.sh#L17-L21 # lists all tests for the specific test type _list

Re: Some tests are never executed in CI due to their name

>> It's unclear to me how the combination of "Has @Test, is not an abstract >> class top level matching file, and is inside the test folder" is going to >> significantly break anything. Maybe I'm missing something; would love to >> learn. I just don't see where you want to "hook" this step exac

Re: Some tests are never executed in CI due to their name

So to be clear, I don't really feel super strongly on this, I just thought Derek's suggestion seemed clean and elegant. Checkstyle to force a certain naming convention on things is fine enough; I certainly wouldn't stand in the way. Tooling like that self-educates users (see: Guardrails) so it's

Re: Some tests are never executed in CI due to their name

I think we are already adhering to them without any effort. Overwhelming majority of devs are naming their tests "just right" and I do not think they are doing that with any significant effort, probably none. We are only re-enforcing the unspoken everybody implicitly agreed on. If somebody does

Re: Some tests are never executed in CI due to their name

> I do not think that having a test class called "SdsdakASsdadsada" which > happen to contain @Test and is not abstract should be considered to be a > valid file name / test class I mean, I wouldn't recommend it certainly, but I'm not concerned about whether a file is "TestThing" or "ThingTest"

[Marketing] For Review: Changelog blog #20 - October

Changelog #20, the overview blog for October is open for 72-hr community review. Please leave comments and amendments using the comment function. https://docs.google.com/document/d/1FKX3N5NQ2KAPKwljEiWYDG-A7w5Z70EyFNc6IVYmqms/edit?usp=sharing Thanks, -- Chris Thornett Senior Content Strategist,

Re: Some tests are never executed in CI due to their name

I always hit "send" before realizing I have other points to add :) I was thinking we want to go with checkstyle and check the name. Not manually parsing the file names. Do not we also want these test files to look consistent? I do not think that having a test class called "SdsdakASsdadsada" whi

Re: Some tests are never executed in CI due to their name

I do not think there is any module in checkstyle which would do what you want. From: Josh McKenzie Sent: Monday, October 31, 2022 12:49 To: dev Subject: Re: Some tests are never executed in CI due to their name NetApp Security WARNING: This is an external

Re: Some tests are never executed in CI due to their name

To Derek's point, why not go with: > Would it be sufficient to look for files that don't end in "Test.java" but > contain "@Test" annotations? + exclude files that contain "abstract class" in them that matches the file name? Combine that w/checking specific subdirectories and we relax the requi