Re: [DISCUSS] Adding dependency on agrona

2022-09-28 Thread Benedict
Also +1 > On 23 Sep 2022, at 18:17, David Capwell wrote: > > +1 from me > >> On Sep 23, 2022, at 1:21 AM, Branimir Lambov >> wrote: >> >> The usage in the trie memtable is only for volatile access to buffers. In >> this case I chose the library instead of reimplementing the functionality

Re: [DISCUSS] Revising our release criteria, commit guidelines, and the role of circleci vs. ASF CI

2022-09-28 Thread Josh McKenzie
So revised proposal: On Release Lifecycle cwiki page: - Ensure we have parity on jobs run between circle and asf-ci - Allow usage of circleci as gatekeeper for releases. 1 green run -> beta, 3 green runs consecutive -> ga - No new consistent regressions on CI for asf compared to prior branches

Re: [DISCUSS] Revising our release criteria, commit guidelines, and the role of circleci vs. ASF CI

2022-09-28 Thread Ekaterina Dimitrova
If we talk blockers nothing more than ensuring we see all tests we want pre-release, IMHO. The other points sound to me like future important improvements that will help us significantly in the flaky test fight. On Wed, 28 Sep 2022 at 10:08, Josh McKenzie wrote: > I'm receptive to that but I wou

Re: [DISCUSS] Revising our release criteria, commit guidelines, and the role of circleci vs. ASF CI

2022-09-28 Thread Josh McKenzie
I'm receptive to that but I wouldn't gate our ability to get 4.1 out the door based on circle on that. Honestly probably only need to have the parity of coverage be the blocker for its use in retrospect. On Wed, Sep 28, 2022, at 1:32 AM, Berenguer Blasi wrote: > I would add an option for generat