Re: [Proposal] add pull request template

2022-08-16 Thread Josh McKenzie
> something more descriptive like "Describe what the pull request fixes, why it > is needed, and what branch(s) you expect it to be applied to." I recall us having a conversation a long while ago about our commit messages and whether they're optimal in their current format (defer all context to J

Re: [Proposal] add pull request template

2022-08-16 Thread Erick Ramirez
I forgot to mention that whatever gets decided, I think it should be implemented across all GitHub repos of the project. See here for the complete list -- https://projects.apache.org/committee.html?cassandra. Cheers!

Re: [Proposal] add pull request template

2022-08-16 Thread Claude Warren, Jr via dev
I am all for simplification. How about - start of text Issue resolved: CASSANDRA- - [ ] Jira ticket contains a description of: what is fixed, why it is needed, and what branches to apply it to. - [ ] Commits have been squashed to remove intermediate development commit message

Re: [Proposal] add pull request template

2022-08-16 Thread Erick Ramirez
Sorry. I hit "send" before pasting the link: [1] https://cassandra.apache.org/_/development/patches.html

Re: [Proposal] add pull request template

2022-08-16 Thread Erick Ramirez
+1 this is a great idea. But personally, I'm not too fussed about the level of detail that is in the template -- what is important is that contributors are reminded that there needs to be a ticket associated with contributions. Without being too prescriptive, aspiring contributors should really fam