Re: [DISCUSS] Should we deprecate / freeze python dtests

2022-03-28 Thread bened...@apache.org
> Other than that, it can be problematic to test upgrades when the starting > version must run with a different Java version than the end release python upgrade tests seem to be particularly limited (from a quick skim, primarily testing major upgrade points that are now long in the past), so I’m

Re: [DISCUSS] Should we deprecate / freeze python dtests

2022-03-28 Thread Jacek Lewandowski
Although I like in-jvm DTests for many scenarios, I can see that they do not test the production code as it is. They use a separate implementation of instance initialization and thus they test the test server rather than the real node. Other than that, it can be problematic to test upgrades when th

Re: [DISCUSS] Next release cut

2022-03-28 Thread David Capwell
I agree with * Fork may 1st * Freeze cassandra-4.1 on may 1st > On Mar 9, 2022, at 1:23 AM, Benjamin Lerer wrote: > > We also have the requirement that there will be no release without green CI. > Do we cut a release branch on the 1st May if we don't yet have a green CI and > can't be making

Re: Fw: GSOD 2022

2022-03-28 Thread Lorina Poland
I did not. We'll figure out the best way to do this for next year. On Fri, Mar 25, 2022 at 3:59 PM Deepak Vohra wrote: > I don't know if you applied. > [Season of Docs - Announcements] Organization application phase is now > closed > > - Forwarded Message - > *From:* Deepak Vohra > *To:

Re: [DISCUSS] Should we deprecate / freeze python dtests

2022-03-28 Thread David Capwell
I am back and the work for trunk to support vnode is at the last stage of review; I had not planned to backport the changes to other branches (aka, older branches would only support single token), so if someone would like to pick up this work it is rather LHF after 17332 goes in (see trunk patch

Shutting down of all scheduled executors in StorageService#drain

2022-03-28 Thread Stefan Miklosovic
Hi, We are implementing a feature which relies on the fact that the executor for periodic tasks is shut down on drain which is not happening now (o.a.c.concurrent.ScheduledExecutors.scheduledTasks). I want to ask if there is some reason we are not shutting down all executors in StorageService#dra

Re: UDF: adding custom jar to classpath

2022-03-28 Thread Sébastien Rebecchi
Unfortunately, it is not working even with "enable_user_defined_functions_threads: false" in cassandra.yaml :/ Is there any way to check the running configuration? Le lun. 28 mars 2022 à 15:35, Benjamin Lerer a écrit : > I do not think that allowing to customize UDF classes whitelist has been >

Re: UDF: adding custom jar to classpath

2022-03-28 Thread Benjamin Lerer
I do not think that allowing to customize UDF classes whitelist has been discussed before. Feel free to open a JIRA ticket :-) I have some plans to revisit how we securise UDFs as the current threading approach has some impact in terms of latency. That can be a good opportunity to look into providi

Re: UDF: adding custom jar to classpath

2022-03-28 Thread Sébastien Rebecchi
Thanks you very much! I will try that. As you know, would it be a long-terms solution? Or is there any plan to add the possibility to customize UDF classes whitelist? Le lun. 28 mars 2022 à 14:31, Benjamin Lerer a écrit : > Is there a way to customize that default behaviour? > > > Looking at Jav

Re: UDF: adding custom jar to classpath

2022-03-28 Thread Benjamin Lerer
> > Is there a way to customize that default behaviour? Looking at JavaBasedUDFunction quickly it seems that the ClassLoader is only used when you use the UDFExecutorService to execute your UDFs. You can try to disable it using "enable_user_defined_functions_threads: false" and see if it works. N

Re: UDF: adding custom jar to classpath

2022-03-28 Thread Sébastien Rebecchi
Hi Benjamin, Thanks for the answer. Is there a way to customize that default behaviour? If no, could you indicate where to find this class loader in the github of Cassandra please? Le lun. 28 mars 2022 à 12:40, Benjamin Lerer a écrit : > Hi Sébastien, > > Cassandra uses a special classloader fo

Re: UDF: adding custom jar to classpath

2022-03-28 Thread Benjamin Lerer
Hi Sébastien, Cassandra uses a special classloader for UDFs that limit which classes can be used. You cannot rely on non-JDK classes for UDFs and some of the JDK packages like the IO package for example cannot be used. The goal is simply to ensure that UDFs cannot compromise the server security.

UDF: adding custom jar to classpath

2022-03-28 Thread Sébastien Rebecchi
Hello, I am trying to create a UDF based on custom methods. So I set enable_user_defined_functions to true and added a jar in "/usr/share/cassandra/lib/" folder on every node, restarted the nodes and I can see from the command line that the jar is indeed used (in the classpath with -cp). But when