Re: [DISCUSS] CASSANDRA-15234

2021-10-20 Thread bened...@apache.org
Thanks for moving this forwards Ekaterina. I think what we perhaps discovered is that there’s not really any consensus about how to best do config files. I think in this situation it’s best to defer to the one who’s actually putting in the time to _do_, so I am more than happy to defer to your

Re: [DISCUSS] CASSANDRA-15234

2021-10-20 Thread Ekaterina Dimitrova
Hi everyone, I think it is time to summarize the discussion. First of all, thank you for all the valuable input, suggestions, concerns, and comments! The things that I believe we all agree on: - Simplicity for maintenance on our end - automation as much as possible so we don’t have to

Re: Save CircleCI resources with optional test jobs

2021-10-20 Thread Andrés de la Peña
Hi all, As Ekaterina has mentioned I’ll be OOO until Monday, and I won’t be able to make any changes until then. Alex, I missed to answer your suggestion about building on every commit, apologies for that. The discussion was open on multiple fronts and I somehow missed that one. I can easily chan

Re: Save CircleCI resources with optional test jobs

2021-10-20 Thread bened...@apache.org
Perhaps instead of a one-size-fits-all policy we should look to improve scripting here anyway. We already have to overwrite the config file, it would seem easy enough to instead invoke a script that enables the relevant workflows? If we choose to just stick with a single workflow, I don’t have a

Re: Save CircleCI resources with optional test jobs

2021-10-20 Thread Stefan Miklosovic
Hi Ekaterina, all, If you eventually decide to switch it to automatic build on push (I like how it is now though), I would appreciate it if there was some option in generation scripts (generate.sh) so I could just have some shortcut / alias which would disable this very easily. It would be very n

Re: Save CircleCI resources with optional test jobs

2021-10-20 Thread Ekaterina Dimitrova
Hi everyone, First of all, I know Andres is off these days so he might not be following the thread today. I will try to clear the situation as the committer who approved the change. Alex, I would like to apologize to you! You are right, I personally didn’t have your email (sometimes gmail plays g

Re: Save CircleCI resources with optional test jobs

2021-10-20 Thread bened...@apache.org
I think this would be fine if there were a way for approval of later steps to trigger the build automatically. As it is we have to traverse the dependency graph manually, which is a bit weird. I can’t figure out a way to do this with the CircleCI API however. It might be a feature request, and

Re: Save CircleCI resources with optional test jobs

2021-10-20 Thread Oleksandr Petrov
I thought this discussion was still ongoing, but it looks like CASSANDRA-16882 is now committed. Could you give some context on why at least compilation is not done on every commit now? On Fri, Oct 8, 2021 at 4:12 PM Oleksandr Petrov wrote: > I personally rarely push tickets/post a patch in an