Re: [Patch Available for Review!] CASSANDRA-14134: Migrate dtests to use pytest and python3

2018-01-09 Thread Nate McCall
Making these tests more accessible and reliable is super huge. There are a lot of folks in our community who are not well versed with python (myself included). I wholly support *any* efforts we can make for the dtest process to be easy. Thanks a bunch for taking this on. I think it will pay off qu

Re: [Patch Available for Review!] CASSANDRA-14134: Migrate dtests to use pytest and python3

2018-01-09 Thread Michael Kjellman
hi! a few of us have been continuously iterating on the dtest-on-pytest branch now since the 2nd and we’ve run the dtests close to 600 times in ci. ariel has been working his way thru a formal review (three cheers for ariel!) flaky tests are a real thing and despite a few dozen totally green te

Re: CASSANDRA-8527

2018-01-09 Thread kurt greaves
I think tombstone rows is more appropriate. Calling them deleted rows initially confused me and it took a few reads of the problem for me to work it out. Especially when you put it in context and "tombstone cells" follows.​

Re: CASSANDRA-8527

2018-01-09 Thread Aleksey Yeshchenko
Sorry, don’t have strong feelings or suggestions regarding naming in logs/warnings. But I agree with this behaviour. — AY On 5 January 2018 at 19:31:58, Alexander Dejanovski (a...@thelastpickle.com) wrote: Right, I think naming it "deleted rows" is misleading because it suggests that 100 ro