I think that Netty is a good example of comments, at least for me they
often were helpful, both from perspective of working on the code and from
user perspective (when something seems to be working not as expected, you
can usually find out reasons for it from the code in a straightforward
way).
I
On Wed, May 4, 2016 at 2:27 AM, Sylvain Lebresne
wrote:
> On Tue, May 3, 2016 at 6:57 PM, Eric Evans
> wrote:
>
> > On Mon, May 2, 2016 at 11:26 AM, Sylvain Lebresne
> > wrote:
> > > Looking forward to other's opinions and feedbacks on this proposal.
> >
> > We might want to leave just a little
Github user thobbs commented on the pull request:
https://github.com/apache/cassandra/commit/55f7a53e44b5d9af767464872b74a721717ba216#commitcomment-17355570
In src/java/org/apache/cassandra/cql3/Maps.java:
In src/java/org/apache/cassandra/cql3/Maps.java on line 470:
Same commen
Github user thobbs commented on the pull request:
https://github.com/apache/cassandra/commit/55f7a53e44b5d9af767464872b74a721717ba216#commitcomment-17355539
In src/java/org/apache/cassandra/cql3/Maps.java:
In src/java/org/apache/cassandra/cql3/Maps.java on line 399:
Setting on
On Tue, May 3, 2016 at 6:57 PM, Eric Evans
wrote:
> On Mon, May 2, 2016 at 11:26 AM, Sylvain Lebresne
> wrote:
> > Looking forward to other's opinions and feedbacks on this proposal.
>
> We might want to leave just a little wiggle room for judgment on the
> part of the reviewer, for the very sim
