Re: Possible issue with read repair?

2012-10-10 Thread Jonathan Ellis
You're both right -- "read repair" as a concept is indeed performed asynchronously, but RowRepairResolver is used for synchronous, high-CL reads as well, which is the code Niklas is referring to. Niklas, can you create a ticket to fix this officially? On Wed, Oct 10, 2012 at 3:31 PM, Mikhail Panc

Possible issue with read repair?

2012-10-10 Thread Niklas Ekström
Hi, I’m looking in the file StorageProxy.java (Cassandra 1.1.5), and line 766 seems odd to me. FBUtilities.waitOnFutures() is called with the repairResults from the RowRepairResolver resolver. The problem though is that repairResults is only assigned when the object is created at line 737 in

Re: Possible issue with read repair?

2012-10-10 Thread Mikhail Panchenko
I'll take a stab: Without looking at the code, that seems perfectly fine - the purpose of read repair is to repair potentially stale data out of band. It is acceptable (from the viewpoint of the datastore) to have "stale" reads while read-repair happens in the background. Once the repair is comple

Possible issue with read repair?

2012-10-10 Thread Niklas Ekström
Hi, I’m looking in the file StorageProxy.java (Cassandra 1.1.5), and line 766 seems odd to me. FBUtilities.waitOnFutures() is called with the repairResults from the RowRepairResolver resolver. The problem though is that repairResults is only assigned when the object is created at line 737 in

Re: [VOTE] Release Apache Cassandra 1.1.6

2012-10-10 Thread Jonathan Ellis
Also: https://issues.apache.org/jira/browse/CASSANDRA-4782 On Tue, Oct 9, 2012 at 5:02 PM, Jonathan Ellis wrote: > Just committed a fix for possible infinite L0 compaction in LCS > (f34bd79b9a92f23c1fc5e185e074d7faa880fc0b), can we include that? > > On Tue, Oct 9, 2012 at 11:12 AM, Jonathan Ellis

Re: cassandra tests

2012-10-10 Thread Brandon Williams
On Wed, Oct 10, 2012 at 3:54 AM, Alexey Zotov wrote: > Are there some another tests, except included to the project? If no, then I > suggest to create pack of integration tests based on ccm. It requires > additional writing of scripts for more deep configuration and management of > ccm's cluster.

cassandra tests

2012-10-10 Thread Alexey Zotov
Hi Guys, I tried to write some tests for HH mechanism, but I couldn't do what I want. Tests writing mechanism is inconvenient and should be improved. I understand that it's not easy to fix it. As the first step I suggest to include some mock framework, e.g. PowerMock (as most powerful as I know),